Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Terraform]: Remove service_account_id from data.google_service_account_key #676

Merged

Conversation

rileykarson
Copy link
Member

hashicorp/terraform-provider-google#1203

I seriously can't explain why the _errors test worked before; ExpectError catches the first error, but then when trying to destroy the resources the error happens again blocking it.


[all]

[terraform]

Remove service_account_id from data.google_service_account_key

[terraform-beta]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#80
depends: hashicorp/terraform-provider-google#2397

rileykarson and others added 2 commits November 5, 2018 15:56
@modular-magician modular-magician merged commit b1782c9 into GoogleCloudPlatform:master Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants