Added backup support for `google_filestore_instance` #6742

googlerjk · 2022-10-26T09:39:49Z

Added resource google_filestore_backup
Added sourceBackup field to google_filestore_instance resource
fixes hashicorp/terraform-provider-google#7655

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_filestore_backup`

mmv1/products/filestore/api.yaml

mmv1/products/redis/api.yaml

mmv1/third_party/validator/tests/data/example_filestore_backup.json

mmv1/products/filestore/api.yaml

modular-magician · 2022-11-10T21:36:31Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 964 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 8 files changed, 964 insertions(+), 4 deletions(-))
TF Validator: Diff ( 4 files changed, 104 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 5 files changed, 142 insertions(+), 1 deletion(-))

modular-magician · 2022-11-10T22:15:19Z

Tests analytics

Total tests: 2236
Passed tests 1993
Skipped tests: 241
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFilestoreInstance_filestoreInstanceFullExample|TestAccFilestoreBackup_filestoreBackupFullExample

googlerjk · 2022-11-11T18:34:06Z

/gcbrun

modular-magician · 2022-11-11T18:51:09Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 964 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 8 files changed, 964 insertions(+), 4 deletions(-))
TF Validator: Diff ( 4 files changed, 104 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 5 files changed, 142 insertions(+), 1 deletion(-))

modular-magician · 2022-11-11T19:40:25Z

Tests analytics

Total tests: 2244
Passed tests 2000
Skipped tests: 241
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFilestoreInstance_filestoreInstanceFullExample|TestAccFilestoreBackup_filestoreBackupFullExample|TestAccComputeForwardingRule_update

modular-magician · 2022-11-11T20:14:35Z

Tests passed during RECORDING mode:
TestAccComputeForwardingRule_update[Debug log]

Tests failed during RECORDING mode:
TestAccFilestoreInstance_filestoreInstanceFullExample[Error message] [Debug log]
TestAccFilestoreBackup_filestoreBackupFullExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-11-15T00:00:47Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 994 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 8 files changed, 994 insertions(+), 4 deletions(-))
TF Validator: Diff ( 4 files changed, 104 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 5 files changed, 157 insertions(+), 1 deletion(-))

modular-magician · 2022-11-15T00:50:51Z

Tests analytics

Total tests: 2255
Passed tests 2011
Skipped tests: 241
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeForwardingRule_update|TestAccFilestoreInstance_filestoreInstanceFullExample|TestAccFilestoreBackup_filestoreBackupBasicExample

modular-magician · 2022-11-15T01:08:50Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 994 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 8 files changed, 994 insertions(+), 4 deletions(-))
TF Validator: Diff ( 4 files changed, 104 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 5 files changed, 157 insertions(+), 1 deletion(-))

modular-magician · 2022-11-15T01:52:24Z

Tests analytics

Total tests: 2255
Passed tests 2010
Skipped tests: 241
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccFilestoreBackup_filestoreBackupBasicExample|TestAccFilestoreInstance_filestoreInstanceFullExample|TestAccComputeForwardingRule_update

modular-magician · 2022-11-15T01:53:45Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeForwardingRule_update[Debug log]

Tests failed during RECORDING mode:
TestAccFilestoreBackup_filestoreBackupBasicExample[Error message] [Debug log]
TestAccFilestoreInstance_filestoreInstanceFullExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-11-15T19:39:23Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 994 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 8 files changed, 994 insertions(+), 4 deletions(-))
TF Validator: Diff ( 4 files changed, 104 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 5 files changed, 157 insertions(+), 1 deletion(-))

modular-magician · 2022-11-15T20:28:06Z

Tests analytics

Total tests: 2257
Passed tests 2013
Skipped tests: 241
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFilestoreBackup_filestoreBackupBasicExample|TestAccFilestoreInstance_filestoreInstanceFullExample|TestAccFirebaserulesRelease_BasicRelease

modular-magician · 2022-11-15T20:33:51Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccFilestoreBackup_filestoreBackupBasicExample[Error message] [Debug log]
TestAccFilestoreInstance_filestoreInstanceFullExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-11-15T21:18:30Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 968 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 8 files changed, 968 insertions(+), 4 deletions(-))
TF Validator: Diff ( 4 files changed, 104 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 5 files changed, 144 insertions(+), 1 deletion(-))

modular-magician · 2022-11-15T22:09:20Z

Tests analytics

Total tests: 2260
Passed tests 2017
Skipped tests: 241
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFilestoreInstance_filestoreInstanceFullExample|TestAccFilestoreBackup_filestoreBackupBasicExample

modular-magician · 2022-11-15T22:14:44Z

Tests failed during RECORDING mode:
TestAccFilestoreInstance_filestoreInstanceFullExample[Error message] [Debug log]
TestAccFilestoreBackup_filestoreBackupBasicExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-11-16T18:52:19Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 995 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 8 files changed, 995 insertions(+), 4 deletions(-))
TF Validator: Diff ( 4 files changed, 114 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 5 files changed, 144 insertions(+), 1 deletion(-))

modular-magician · 2022-11-16T19:34:49Z

Tests analytics

Total tests: 2268
Passed tests 2025
Skipped tests: 241
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFilestoreBackup_filestoreBackupBasicExample|TestAccFilestoreInstance_filestoreInstanceFullExample

modular-magician · 2022-11-16T19:49:13Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 997 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 8 files changed, 997 insertions(+), 6 deletions(-))
TF Validator: Diff ( 4 files changed, 114 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 5 files changed, 145 insertions(+), 2 deletions(-))

modular-magician · 2022-11-16T20:36:52Z

Tests analytics

Total tests: 2268
Passed tests 2025
Skipped tests: 241
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFilestoreInstance_filestoreInstanceFullExample|TestAccFilestoreBackup_filestoreBackupBasicExample

modular-magician · 2022-11-16T20:42:44Z

Tests failed during RECORDING mode:
TestAccFilestoreInstance_filestoreInstanceFullExample[Error message] [Debug log]
TestAccFilestoreBackup_filestoreBackupBasicExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

Co-authored-by: Cameron Thornton <[email protected]> Update mmv1/products/redis/api.yaml Co-authored-by: Cameron Thornton <[email protected]> Update mmv1/products/filestore/api.yaml Co-authored-by: Cameron Thornton <[email protected]> validator files removed, updates for filestore source backup field quota lowered and label fixed rm api.yaml api.yaml added

c2thorn · 2022-12-07T17:29:19Z

I tested it locally and it doesn't seem the backup name is returned for the field source_backup in google_filestore_instance. Filestore instance and backup got created successfully though. Do you happen to know why it's not got returned?

It's only returned when an instance is restored from a backup, which won't be possible to do in TF without using the custom "restore" endpoint. Julius and I confirmed the field is returned as expected from the API by manually restoring an instance. Given that this is an output-only field, I feel confident enough with that manual check.

c2thorn

My apologies for missing this up to this point, but we really need to add a test for updatability. Can you write a handwritten test to check the updatability of description and labels ?

mmv1/products/filestore/api.yaml

googlerjk · 2022-12-08T21:40:03Z

@googlerjk The latest commit does not seem to address all the comments @c2thorn left. Is this the latest version? Sorry if I have missed anything. Comments that need to be addressed:

what's the purpose of modifying example at mmv1/templates/terraform/examples/filestore_instance_full.tf.erb? The goal of that example is to test the google_filestore_instance resource

input: true is added to nfsExportOptions in google_filestore_instance resource? Is that intentional?

this has been applied.

modular-magician · 2022-12-08T22:15:47Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 1082 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 8 files changed, 1082 insertions(+), 2 deletions(-))
TF Validator: Diff ( 4 files changed, 114 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 131 insertions(+))

modular-magician · 2022-12-08T23:05:06Z

Tests analytics

Total tests: 2336
Passed tests 2089
Skipped tests: 244
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccFilestoreBackup_update|TestAccLoggingBucketConfigProject_cmekSettings

modular-magician · 2022-12-08T23:11:35Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccFilestoreBackup_update[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]

All tests passed
View the build log or the debug log for each test

googlerjk · 2022-12-09T11:45:51Z

My apologies for missing this up to this point, but we really need to add a test for updatability. Can you write a handwritten test to check the updatability of description and labels ?

Update made and pushed

outdated

googlerjk requested a review from c2thorn October 26, 2022 09:39

googlerjk self-assigned this Oct 26, 2022

googlerjk changed the title ~~Jk adding filestore backup support~~ Added backup support for google_filestore_instance Oct 28, 2022

c2thorn requested changes Nov 1, 2022

View reviewed changes

modular-magician requested a review from c2thorn November 2, 2022 19:59

googlerjk force-pushed the jk-adding-filestore-backup-support branch from ffb2671 to 8ceed51 Compare November 10, 2022 21:21

googlerjk force-pushed the jk-adding-filestore-backup-support branch from 14249b8 to 6eda6d6 Compare November 10, 2022 23:26

googlerjk requested a review from rileykarson as a code owner November 22, 2022 02:22

googlerjk and others added 11 commits December 7, 2022 00:08

test renamed to basic

321be3f

increase gb of storage fixed labels

12712c3

increase gb

dca838b

increase updated source_instance

33eb300

source_input validator removed

2ae5cb0

shorter test name

e3fb5d4

source instance set to use id

9404f00

shortened param value

a7e3fb3

removed input:true from nfsExportOptions

3350174

removed backup from full filestore test

ea756a0

c2thorn requested changes Dec 7, 2022

View reviewed changes

mmv1/products/filestore/api.yaml Show resolved Hide resolved

added handwritted tests to validate field updates

785c629

googlerjk force-pushed the jk-adding-filestore-backup-support branch from fbdfacd to 785c629 Compare December 8, 2022 21:59

modular-magician requested review from c2thorn and shuyama1 December 8, 2022 22:00

c2thorn approved these changes Dec 9, 2022

View reviewed changes

c2thorn removed the request for review from shuyama1 December 9, 2022 18:17

c2thorn merged commit 2f6206c into GoogleCloudPlatform:main Dec 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added backup support for `google_filestore_instance` #6742

Added backup support for `google_filestore_instance` #6742

googlerjk commented Oct 26, 2022 •

edited

Loading

modular-magician commented Nov 10, 2022

modular-magician commented Nov 10, 2022

googlerjk commented Nov 11, 2022

modular-magician commented Nov 11, 2022

modular-magician commented Nov 11, 2022

modular-magician commented Nov 11, 2022

modular-magician commented Nov 15, 2022

modular-magician commented Nov 15, 2022

modular-magician commented Nov 15, 2022

modular-magician commented Nov 15, 2022

modular-magician commented Nov 15, 2022

modular-magician commented Nov 15, 2022

modular-magician commented Nov 15, 2022

modular-magician commented Nov 15, 2022

modular-magician commented Nov 15, 2022

modular-magician commented Nov 15, 2022

modular-magician commented Nov 15, 2022

modular-magician commented Nov 16, 2022

modular-magician commented Nov 16, 2022

modular-magician commented Nov 16, 2022

modular-magician commented Nov 16, 2022

modular-magician commented Nov 16, 2022

c2thorn commented Dec 7, 2022

c2thorn left a comment

googlerjk commented Dec 8, 2022

modular-magician commented Dec 8, 2022

modular-magician commented Dec 8, 2022

modular-magician commented Dec 8, 2022

googlerjk commented Dec 9, 2022

Added backup support for google_filestore_instance #6742

Added backup support for google_filestore_instance #6742

Conversation

googlerjk commented Oct 26, 2022 • edited Loading

modular-magician commented Nov 10, 2022

Diff report

modular-magician commented Nov 10, 2022

Tests analytics

Action taken

googlerjk commented Nov 11, 2022

modular-magician commented Nov 11, 2022

Diff report

modular-magician commented Nov 11, 2022

Tests analytics

Action taken

modular-magician commented Nov 11, 2022

modular-magician commented Nov 15, 2022

Diff report

modular-magician commented Nov 15, 2022

Tests analytics

Action taken

modular-magician commented Nov 15, 2022

Diff report

modular-magician commented Nov 15, 2022

Tests analytics

Action taken

modular-magician commented Nov 15, 2022

modular-magician commented Nov 15, 2022

Diff report

modular-magician commented Nov 15, 2022

Tests analytics

Action taken

modular-magician commented Nov 15, 2022

modular-magician commented Nov 15, 2022

Diff report

modular-magician commented Nov 15, 2022

Tests analytics

Action taken

modular-magician commented Nov 15, 2022

modular-magician commented Nov 16, 2022

Diff report

modular-magician commented Nov 16, 2022

Tests analytics

Action taken

modular-magician commented Nov 16, 2022

Diff report

modular-magician commented Nov 16, 2022

Tests analytics

Action taken

modular-magician commented Nov 16, 2022

c2thorn commented Dec 7, 2022

c2thorn left a comment

Choose a reason for hiding this comment

googlerjk commented Dec 8, 2022

modular-magician commented Dec 8, 2022

Diff report

modular-magician commented Dec 8, 2022

Tests analytics

Action taken

modular-magician commented Dec 8, 2022

googlerjk commented Dec 9, 2022

Added backup support for `google_filestore_instance` #6742

Added backup support for `google_filestore_instance` #6742

googlerjk commented Oct 26, 2022 •

edited

Loading