[TF] Remove name_prefix from container node pool #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisst
force-pushed
the
deprecate-node-pool-prefix
branch
from
c63545a to
1204399
Compare
|
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
chrisst
force-pushed
the
deprecate-node-pool-prefix
branch
from
1204399 to
b47d3de
Compare
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit e33dcbd) have been included in your existing downstream PRs. |
rileykarson
approved these changes
Oct 30, 2018
chrisst
force-pushed
the
deprecate-node-pool-prefix
branch
from
e9d36c8 to
2bc196f
Compare
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit 184b534) have been included in your existing downstream PRs. |
modular-magician
force-pushed
the
deprecate-node-pool-prefix
branch
from
e22bd7c to
c650de4
Compare
paddycarver
added a commit
that referenced
this pull request
Jan 17, 2019
This reverts #638, as we've decided to keep the name_prefix available for node pools, as per hashicorp/terraform-provider-google#2486.
modular-magician
pushed a commit
that referenced
this pull request
Feb 1, 2019
This reverts #638, as we've decided to keep the name_prefix available for node pools, as per hashicorp/terraform-provider-google#2486.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[all]
Remove name_prefix from container node pool
[terraform]
[terraform-beta]
[ansible]
[inspec]