Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better import for spanner, allow underscore in database names #604

Merged
merged 3 commits into from
Oct 24, 2018
Merged

Add better import for spanner, allow underscore in database names #604

merged 3 commits into from
Oct 24, 2018

Conversation

emilymye
Copy link
Contributor

Redo of #587

[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

@emilymye emilymye requested a review from chrisst October 23, 2018 20:51
@sudoforge
Copy link

Note that this closes #583.

@chrisst
Copy link
Contributor

chrisst commented Oct 23, 2018

@emilymye looks like you're breaking due to testAccSpannerDatabase_basicWithInitialDDL being declared twice:

google/resource_spanner_database_test.go:156:84: testAccSpannerDatabase_basicWithInitialDDL redeclared in this block

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#28
depends: hashicorp/terraform-provider-google#2318

@emilymye emilymye force-pushed the tf_spanner_validation branch from 96c870f to 9a60b9f Compare October 23, 2018 22:01
@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 6c7fade) have been included in your existing downstream PRs.

@emilymye emilymye force-pushed the tf_spanner_validation branch from 9a60b9f to 69136ce Compare October 24, 2018 04:31
@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 2b5840d) have been included in your existing downstream PRs.

@emilymye
Copy link
Contributor Author

@chrisst sorry, the fix fixed it but I need approval on this PR :(

@chrisst
Copy link
Contributor

chrisst commented Oct 24, 2018

You closed the beta PR but it looked like it had a combo of legit changes in addition to pulling in something else.

@emilymye
Copy link
Contributor Author

Ack, reopened beta PR. Should have just waited to do this PR.

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit f2e043b) have been included in your existing downstream PRs.

@emilymye emilymye force-pushed the tf_spanner_validation branch from 2709077 to a268ed2 Compare October 24, 2018 22:14
@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 2ffd717) have been included in your existing downstream PRs.

@emilymye emilymye merged commit 8320b18 into master Oct 24, 2018
@emilymye emilymye deleted the tf_spanner_validation branch October 25, 2018 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisst chrisst chrisst approved these changes

Assignees
No one assigned
Labels
cla: yes downstream-generated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@emilymye @sudoforge @chrisst @modular-magician @googlebot