Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defaults for expr and description to prevent spurious diffs #5997

Merged
merged 2 commits into from
May 6, 2022

Conversation

slevenick
Copy link
Contributor

@slevenick slevenick commented Apr 29, 2022

Fixes: hashicorp/terraform-provider-google#9084

Probably.

Problem sort of explained here (hashicorp/terraform-provider-google#9084 (comment)) where the state value seems to be changing between null & "" which causes the diff on the rule. Setting default values for both description & versioned_expr seems to fix this as far as I can tell

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: fixed extra diffs generated on `google_security_policy` `rules` when modifying a rule

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 2 insertions(+))
Terraform Beta: Diff ( 1 file changed, 2 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1995
Passed tests 1753
Skipped tests: 241
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccBigQueryDataTable_bigtable

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccBigQueryDataTable_bigtable[view]

All tests passed
View the build log or the debug log for each test

@slevenick slevenick requested a review from rileykarson April 29, 2022 23:54
Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unusual! I can't think of a way that this would break existing users so it should be a safe change, although needing it at all is a surprise in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_compute_security_policy rules are always recreated if they have a match expr set
3 participants