Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dcl #5762

Merged
merged 2 commits into from
Feb 28, 2022
Merged

Conversation

slevenick
Copy link
Contributor

Upgrades DCL and fixes serialization issues introduced by changing struct names

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 1247 insertions(+), 665 deletions(-))
Terraform Beta: Diff ( 7 files changed, 1289 insertions(+), 706 deletions(-))
TF Validator: Diff ( 2 files changed, 5 insertions(+), 33 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccEventarcTrigger_BasicHandWritten You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=262735

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccContainerCluster_withAuthenticatorGroupsConfig Please fix these to complete your PR

@slevenick slevenick requested review from a team and rileykarson and removed request for a team February 28, 2022 22:26
@slevenick slevenick merged commit ba0d75a into GoogleCloudPlatform:master Feb 28, 2022
lcaggio pushed a commit to lcaggio/magic-modules that referenced this pull request Mar 16, 2022
* upgrade dcl

* Fix go.sum
lcaggio pushed a commit to lcaggio/magic-modules that referenced this pull request Mar 17, 2022
* upgrade dcl

* Fix go.sum
lcaggio pushed a commit to lcaggio/magic-modules that referenced this pull request Mar 18, 2022
* upgrade dcl

* Fix go.sum
betsy-lichtenberg pushed a commit to betsy-lichtenberg/magic-modules that referenced this pull request Apr 25, 2022
* upgrade dcl

* Fix go.sum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants