Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set exclude for versions recursively on objects/arrays #575

Merged
merged 1 commit into from
Oct 18, 2018

Conversation

emilymye
Copy link
Contributor

Currently this property (Type) method only gets called on direct resource @properties/@parameters.

I'm not sure if this will change other providers, but if it does, they were probably wrong to start with.


[all]

[terraform]

[puppet]

[puppet-bigquery]

[puppet-compute]

[puppet-container]

[puppet-dns]

[puppet-logging]

[puppet-pubsub]

[puppet-resourcemanager]

[puppet-sql]

[puppet-storage]

[chef]

[chef-compute]

[chef-container]

[chef-dns]

[chef-logging]

[chef-spanner]

[chef-sql]

[chef-storage]

[ansible]

[inspec]

@emilymye emilymye force-pushed the nested_exclude_version branch from a53139a to 10db6ed Compare October 17, 2018 20:34
@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!
I checked the downstream repositories (see README.md for which ones I can write to), and none of them seem to have any changes.

Once this PR is approved, you can feel free to merge it without taking any further steps.

@emilymye emilymye force-pushed the nested_exclude_version branch 2 times, most recently from f0e3d40 to 2d93bc2 Compare October 18, 2018 00:13
@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!
I checked the downstream repositories (see README.md for which ones I can write to), and none of them seem to have any changes.

Once this PR is approved, you can feel free to merge it without taking any further steps.

@emilymye emilymye force-pushed the nested_exclude_version branch from 2d93bc2 to 6b8523b Compare October 18, 2018 17:33
@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!
I checked the downstream repositories (see README.md for which ones I can write to), and none of them seem to have any changes.

Once this PR is approved, you can feel free to merge it without taking any further steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants