Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for zone and region via env #5646

Merged
merged 4 commits into from
Jan 28, 2022
Merged

Adding support for zone and region via env #5646

merged 4 commits into from
Jan 28, 2022

Conversation

prateek2408
Copy link
Contributor

@prateek2408 prateek2408 commented Jan 25, 2022

If this PR is for Terraform, I acknowledge that I have:

  • [X ] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [x ] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
    .

Release Note Template for Downstream PRs (will be copied)


This is fix for Issue- GoogleCloudPlatform/terraform-validator#463

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

TF Validator: Diff ( 2 files changed, 60 insertions(+))

@rileykarson rileykarson requested review from melinath and removed request for rileykarson January 25, 2022 17:29
@melinath melinath requested review from ScottSuarez and removed request for melinath January 25, 2022 18:54
Copy link
Contributor

@ScottSuarez ScottSuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the fields here won't compile due to the struct not being declared correctly ^-^

mmv1/third_party/validator/getconfig_test.go Outdated Show resolved Hide resolved
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

TF Validator: Diff ( 2 files changed, 60 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccCloudbuildWorkerPool_basic|TestAccComputeGlobalForwardingRule_externalCndLbWithBackendBucketExample|TestAccServiceNetworkingPeeredDNSDomain_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=249165

@ScottSuarez
Copy link
Contributor

Looks like tests are failing, could you try running the unit tests locally

FAIL	github.com/GoogleCloudPlatform/terraform-validator/converters/google/resources [build failed]
ok  	github.com/GoogleCloudPlatform/terraform-validator/converters/google	0.234s
ok  	github.com/GoogleCloudPlatform/terraform-validator/cmd	0.065s
ok  	github.com/GoogleCloudPlatform/terraform-validator/ancestrymanager	0.101s
?   	github.com/GoogleCloudPlatform/terraform-validator	[no test files]
converters/google/resources/iam_cloud_functions_cloud_function.go:113:12: too many errors
	previous declaration at converters/google/resources/utils.go:59:66
converters/google/resources/getconfig_test.go:28:6: getRegion redeclared in this block
	previous declaration at converters/google/resources/regional_utils.go:29:64
converters/google/resources/getconfig_test.go:25:6: getZone redeclared in this block
	want (*Config)
	have (*schema.ResourceData, *Config)
converters/google/resources/iam_cloud_functions_cloud_function.go:113:24: too many arguments in call to getRegion
converters/google/resources/iam_cloud_functions_cloud_function.go:113:12: assignment mismatch: 2 variables but getRegion returns 1 values
	want (*Config)
	have (TerraformResourceData, *Config)
converters/google/resources/iam_cloud_functions_cloud_function.go:63:24: too many arguments in call to getRegion
converters/google/resources/iam_cloud_functions_cloud_function.go:63:12: assignment mismatch: 2 variables but getRegion returns 1 values
	want (*Config)
	have (TerraformResourceData, *Config)
converters/google/resources/compute_region_disk_resource_policy_attachment.go:71:26: too many arguments in call to getRegion
converters/google/resources/compute_region_disk_resource_policy_attachment.go:71:14: assignment mismatch: 2 variables but getRegion returns 1 values
	want (*Config)
	have (TerraformResourceData, *Config)
converters/google/resources/compute_disk_resource_policy_attachment.go:71:22: too many arguments in call to getZone
converters/google/resources/compute_disk_resource_policy_attachment.go:71:12: assignment mismatch: 2 variables but getZone returns 1 values

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

TF Validator: Diff ( 2 files changed, 60 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

TF Validator: Diff ( 2 files changed, 60 insertions(+))

@ScottSuarez
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

TF Validator: Diff ( 2 files changed, 60 insertions(+))

@ScottSuarez ScottSuarez merged commit ac05fe5 into GoogleCloudPlatform:master Jan 28, 2022
@prateek2408 prateek2408 deleted the support-zone-region branch January 31, 2022 05:45
tsamaras pushed a commit to wayfair-contribs/magic-modules that referenced this pull request Feb 4, 2022
lcaggio pushed a commit to lcaggio/magic-modules that referenced this pull request Mar 16, 2022
lcaggio pushed a commit to lcaggio/magic-modules that referenced this pull request Mar 17, 2022
betsy-lichtenberg pushed a commit to betsy-lichtenberg/magic-modules that referenced this pull request Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants