check in tpg into tfv repository #5641
Conversation
There was a problem hiding this comment.
TFV has historically relied on TPG rather than TPGB (and I would prefer to stick with that, at least for now.) I am tentatively on board with the idea of generating a full copy of the Terraform provider into TFV rather than having it as a dependency since that would give us the same functionality without the associated delays - but it would be great to have a short write-up of the pros & cons of this vs other approaches, since this is a significant architectural change. I'm not sure we should block the linked PR on this since we already have a workaround (temporarily disabling the tests) and the discussion of what to do here might take a few days.
|
@melinath do you have a reference for the workaround? or perhaps we could sync |
|
@ScottSuarez the workaround is moving the impacted tests to https://github.com/GoogleCloudPlatform/magic-modules/tree/master/mmv1/third_party/validator/tests/data-ignored |
ScottSuarez
changed the title
|
marked as safe - /gcbrun |
resolves GoogleCloudPlatform/terraform-validator#323
clone tpg head branch into tfv in generation pipeline.. eventually will remove the dependency of tpgb through gomod file.
Release Note Template for Downstream PRs (will be copied)