Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify iam resource template for terraform converter #5594

Merged
merged 3 commits into from
Jan 7, 2022

Conversation

iyabchen
Copy link
Contributor

@iyabchen iyabchen commented Jan 5, 2022

Modify iam template to adapt to multiple fields in asset name template.

  • Since most of the iam resource have no test cases, so only cloud run service is impacted
  • For storage bucket, the url starts with b/{bucket}, hence disable the auto generation and use a handwritten one. The handwritten one is actually the same as the original auto generated file.
  • Other handwritten iam resource need similar change too, but will put into another PR.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ndmckinley, please review this PR or find an appropriate assignee.

@iyabchen iyabchen requested review from melinath and removed request for nat-henderson January 5, 2022 19:03
@iyabchen iyabchen marked this pull request as ready for review January 5, 2022 19:07
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 1 file changed, 22 insertions(+), 22 deletions(-))
TF Validator: Diff ( 27 files changed, 137 insertions(+), 125 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

TF Validator: Diff ( 27 files changed, 137 insertions(+), 125 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccOsConfigOsPolicyAssignment_FixedOsPolicyAssignment|TestAccOsConfigOsPolicyAssignment_PercentOsPolicyAssignment You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=240655

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It looks like this handles most cases well! There are a couple of edge cases that are currently incorrect, but it might be easier to review fixes for those cases in a separate PR; they could even be considered separate bugs, potentially. This is already a huge improvement over the current state.

  • Storage bucket IAM would be great to get generated again - handwritten files are a significant maintenance burden.
  • Asset names that include segments with camelCase seem to end up being incorrect - for example, private_ca_pool_iam ends up with an asset name that includes ca_pools (should be caPools) EDIT: This seems to be the only example like this.

@melinath
Copy link
Member

melinath commented Jan 7, 2022

I'm going to go ahead and merge this since it is such an improvement over the current state.

@melinath
Copy link
Member

b/211764514

betsy-lichtenberg pushed a commit to betsy-lichtenberg/magic-modules that referenced this pull request Apr 25, 2022
…form#5594)

* iam change

* disable storage bucket iam auto generate

* fix cloud run service iam test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants