-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify iam resource template for terraform converter #5594
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @ndmckinley, please review this PR or find an appropriate assignee. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:TF Validator: Diff ( 27 files changed, 137 insertions(+), 125 deletions(-)) |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccOsConfigOsPolicyAssignment_FixedOsPolicyAssignment|TestAccOsConfigOsPolicyAssignment_PercentOsPolicyAssignment You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=240655 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It looks like this handles most cases well! There are a couple of edge cases that are currently incorrect, but it might be easier to review fixes for those cases in a separate PR; they could even be considered separate bugs, potentially. This is already a huge improvement over the current state.
- Storage bucket IAM would be great to get generated again - handwritten files are a significant maintenance burden.
- Asset names that include segments with camelCase seem to end up being incorrect - for example, private_ca_pool_iam ends up with an asset name that includes
ca_pools
(should becaPools
) EDIT: This seems to be the only example like this.
I'm going to go ahead and merge this since it is such an improvement over the current state. |
b/211764514 |
…form#5594) * iam change * disable storage bucket iam auto generate * fix cloud run service iam test case
Modify iam template to adapt to multiple fields in asset name template.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)