google_os_config_os_policy_assignment

[trodge]

Upgraded DCL and added overrides for osconfig os policy assignment.
Reworked AppendToBasePath override into BasePathReplacement.
Implemented serialization for map[string]string types.

fixes hashicorp/terraform-provider-google#10628

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_os_config_os_policy_assignment`

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 13 files changed, 4918 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 14 files changed, 4925 insertions(+), 14 deletions(-))

[nat-henderson]

This looks fine to me with the exception of the design of the trait. Riley or Sam could overrule me on that point though - I don't feel super strongly about it.

[nat-henderson]

I don't think we want to be putting code in these files. I know it's not much code, but it's really worth avoiding in my opinion. Is that feasible?

[trodge]

It's feasible if we want to keep BasePathReplacement and AppendToBasePath as two separate traits. To me it seems cleaner to combine them into one, even if it means we have to do it like this.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 13 files changed, 4918 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 14 files changed, 4923 insertions(+), 14 deletions(-))

[nat-henderson]

Thank you! Yes, I think this is much better.

[rileykarson]

I haven't reviewed the PR here, I only took a look at the generated code. I'm seeing the v1 part drop from monitored project in the downstream, and I'm not sure I can see where that's getting added back somewhere else: modular-magician/terraform-provider-google-beta@auto-pr-5481-old..auto-pr-5481#diff-4453ffdcd0L94

[rileykarson]

I think that's supported by the VCR failure, where we're making a different request than we did before:

------- Stdout: -------
=== RUN   TestAccMonitoringMonitoredProject_BasicMonitoredProject
=== PAUSE TestAccMonitoringMonitoredProject_BasicMonitoredProject
=== CONT  TestAccMonitoringMonitoredProject_BasicMonitoredProject
provider_test.go:278: Step 1/2 error: Error running apply: exit status 1
Error: Error creating MonitoredProject: failed to create a diff: failed to retrieve MonitoredProject resource: Get "https://monitoring.googleapis.com/locations/global/metricsScopes/ci-test-project-188019?alt=json": Requested interaction not found
on terraform_plugin_test.tf line 2, in resource "google_monitoring_monitored_project" "primary":
2: resource "google_monitoring_monitored_project" "primary" {
--- FAIL: TestAccMonitoringMonitoredProject_BasicMonitoredProject (24.90s)
FAIL

[nat-henderson]

Yep - you're right about that. I'll rereview when the tests are green.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 13 files changed, 4918 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 14 files changed, 4923 insertions(+), 14 deletions(-))

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 13 files changed, 4918 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 13 files changed, 4923 insertions(+), 11 deletions(-))

[nat-henderson]

For some reason, it doesn't seem like re-running the failed VCR tests is running for you. I can't explain that, sorry! Hm, can you maybe run the failed tests on your machine locally? I don't suspect any of them are related, but you never know...

[trodge]

/gcbrun

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 13 files changed, 4918 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 13 files changed, 4923 insertions(+), 11 deletions(-))

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 4902 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 10 files changed, 4907 insertions(+), 5 deletions(-))

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 4902 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 10 files changed, 4907 insertions(+), 5 deletions(-))

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 4902 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 10 files changed, 4907 insertions(+), 5 deletions(-))

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccOSConfigOSPolicyAssignment_FixedOsPolicyAssignment|TestAccOSConfigOSPolicyAssignment_PercentOsPolicyAssignment You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=227053

[modular-magician]

Tests failed during RECORDING mode: TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccApigeeEnvironmentIamBindingGenerated|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccCloudFunctionsFunction_vpcConnector Please fix these to complete your PR

[nat-henderson]

Those are all problems with billing enablement and an internal API error. No need to change anything on those. Works fine for me.

Should we worry about the TF validator?

[nat-henderson]

nope, don't need to worry about that one, known issue seems like.