Private CA - Create expander for X509Config #5368

haydentherapper · 2021-10-25T23:25:17Z

In order to handle the case of optional primitive fields, I've added virtual fields to allow the expander to distinguish between an unset primitive and a primitive set to the default value.

Fixes hashicorp/terraform-provider-google#10108

Fixes hashicorp/terraform-provider-google#10239

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

privateca: added support for setting default values for basic constraints for `google_privateca_certificate`, `google_privateca_certificate_authority`, and `google_privateca_ca_pool` via the `non_ca` and `zero_max_issuer_path_length` fields

modular-magician · 2021-10-25T23:26:38Z

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@c2thorn, please review this PR or find an appropriate assignee.

modular-magician · 2021-10-25T23:37:15Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 387 insertions(+), 1179 deletions(-))
Terraform Beta: Diff ( 9 files changed, 388 insertions(+), 1180 deletions(-))
TF Validator: Diff ( 3 files changed, 39 insertions(+), 1173 deletions(-))

mmv1/products/privateca/terraform.yaml

mmv1/third_party/terraform/utils/privateca_utils.go

slevenick · 2021-10-26T17:43:00Z

mmv1/products/privateca/terraform.yaml

@@ -54,6 +54,21 @@ overrides: !ruby/object:Overrides::ResourceOverrides
          kms_key_name: 'BootstrapKMSKeyWithPurposeInLocation(t, "ASYMMETRIC_SIGN", "us-central1").CryptoKey.Name'
          pool_name: 'BootstrapSharedCaPoolInLocation(t, "us-central1")'
          pool_location: "\"us-central1\""
+    virtual_fields:


Virtual fields are a possible way to make this work, but it seems preferable to have the fields in the same object as the is_ca and max_path_length fields. Do you think it is better to have them at the top level?

are these top-level fields on the CA resource?

Virtual fields are top-level only. They could be added to the sub object itself if done a slightly different way

Did you have an example of how to add this as a virtual-like field as a subject object?

There is not a significant benefit to having these as top-level objects, but it seemed like virtual fields were the simplest approach.

I don't have an example off hand, but any field that is marked as url_param_only should not be sent in the request body and not read from an API response

We've updated the PR to use url_param_only, please take a look!

pmansour

(left initial feedback on first few files, will look at the rest soon)

pmansour · 2021-10-26T20:44:26Z

mmv1/products/privateca/terraform.yaml

@@ -54,6 +54,21 @@ overrides: !ruby/object:Overrides::ResourceOverrides
          kms_key_name: 'BootstrapKMSKeyWithPurposeInLocation(t, "ASYMMETRIC_SIGN", "us-central1").CryptoKey.Name'
          pool_name: 'BootstrapSharedCaPoolInLocation(t, "us-central1")'
          pool_location: "\"us-central1\""
+    virtual_fields:


are these top-level fields on the CA resource?

mmv1/products/privateca/terraform.yaml

mmv1/templates/terraform/custom_expand/privateca_certificate_509_config.go.erb

haydentherapper · 2021-10-29T20:18:00Z

/gcbrun

haydentherapper · 2021-10-29T20:26:26Z

Failed tests from terraform-validator-test are from https://github.com/GoogleCloudPlatform/terraform-validator/blob/main/converters/google/resources/privateca_certificate.go. That file should be automatically updated from magic modules, so I assume this will resolve after submission.

modular-magician · 2021-10-29T20:27:38Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 372 insertions(+), 1179 deletions(-))
Terraform Beta: Diff ( 8 files changed, 372 insertions(+), 1179 deletions(-))
TF Validator: Diff ( 3 files changed, 39 insertions(+), 1173 deletions(-))

modular-magician · 2021-10-29T20:54:53Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 380 insertions(+), 1179 deletions(-))
Terraform Beta: Diff ( 10 files changed, 380 insertions(+), 1179 deletions(-))
TF Validator: Diff ( 3 files changed, 39 insertions(+), 1173 deletions(-))
TF OiCS: Diff ( 2 files changed, 4 insertions(+))

mmv1/products/privateca/terraform.yaml

slevenick · 2021-11-09T17:31:28Z

mmv1/products/privateca/terraform.yaml

@@ -54,6 +54,21 @@ overrides: !ruby/object:Overrides::ResourceOverrides
          kms_key_name: 'BootstrapKMSKeyWithPurposeInLocation(t, "ASYMMETRIC_SIGN", "us-central1").CryptoKey.Name'
          pool_name: 'BootstrapSharedCaPoolInLocation(t, "us-central1")'
          pool_location: "\"us-central1\""
+    virtual_fields:


I don't have an example off hand, but any field that is marked as url_param_only should not be sent in the request body and not read from an API response

mmv1/third_party/terraform/utils/privateca_utils.go

In order to handle the case of optional primitive fields, I've added virtual fields to allow the expander to distinguish between an unset primitive and a primitive set to the default value. Since some Private CA resources do not support updates, I also added support for setting ForceNew in the terraform config.

This prevents incompatiable configs that set the allow* booleans without setting basic constraints, and vice versa.

modular-magician · 2021-11-15T22:06:46Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 380 insertions(+), 1179 deletions(-))
Terraform Beta: Diff ( 10 files changed, 380 insertions(+), 1179 deletions(-))
TF Validator: Diff ( 3 files changed, 39 insertions(+), 1173 deletions(-))
TF OiCS: Diff ( 2 files changed, 4 insertions(+))

modular-magician · 2021-11-15T23:56:59Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccAssuredWorkloadsWorkload_FullHandWritten|TestAccAssuredWorkloadsWorkload_BasicHandWritten|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccComputeInstanceFromMachineImage_basic|TestAccComputeInstanceFromMachineImage_overrideMetadataDotStartupScript|TestAccComputeInstanceFromMachineImage_diffProject|TestAccComputeRegionHealthCheck_tcp_update|TestAccComputeRegionHealthCheck_typeTransition|TestAccComputeRegionHealthCheck_logConfigDisabled|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccContainerCluster_withILBSubsetting|TestAccContainerCluster_regionalWithNodePool|TestAccContainerCluster_withNodePoolBasic|TestAccContainerCluster_withNodePoolUpdateVersion|TestAccContainerCluster_withNodePoolResize|TestAccContainerCluster_withNodePoolAutoscaling|TestAccContainerCluster_withNodePoolMultiple|TestAccContainerCluster_withNodePoolNodeConfig|TestAccContainerCluster_withEnableKubernetesAlpha|TestAccContainerNodePool_basic|TestAccContainerNodePool_nodeLocations|TestAccContainerNodePool_basicWithClusterId|TestAccContainerNodePool_maxPodsPerNode|TestAccContainerNodePool_withNodeConfig|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccContainerNodePool_withSandboxConfig|TestAccContainerNodePool_withKubeletConfig|TestAccContainerNodePool_withLinuxNodeConfig|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccContainerNodePool_withGPU|TestAccContainerNodePool_withManagement|TestAccContainerNodePool_withNodeConfigScopeAlias|TestAccContainerNodePool_regionalAutoscaling|TestAccContainerNodePool_autoscaling|TestAccContainerNodePool_resize|TestAccContainerNodePool_version|TestAccContainerNodePool_regionalClusters|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerNodePool_EmptyGuestAccelerator|TestAccContainerNodePool_ephemeralStorageConfig|TestAccDataprocWorkflowTemplate_basic|TestAccEventarcTrigger_BasicHandWritten|TestAccMonitoringMonitoredProject_BasicMonitoredProject|TestAccNetworkServicesEdgeCacheOrigin_networkServicesEdgeCacheOriginBasicExample|TestAccNetworkServicesEdgeCacheOrigin_networkServicesEdgeCacheOriginAdvancedExample|TestAccNetworkServicesEdgeCacheService_networkServicesEdgeCacheServiceAdvancedExample|TestAccOrgPolicyPolicy_EnforcePolicy|TestAccOrgPolicyPolicy_FolderPolicy|TestAccOrgPolicyPolicy_ProjectPolicy|TestAccPrivatecaCaPool_privatecaCapoolAllFieldsExample|TestAccPrivatecaCaPool_privatecaCapoolUpdate|TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityBasicExample|TestAccPrivatecaCertificate_privatecaCertificateConfigExample|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccPrivatecaCertificate_privatecaCertificateCsrExample|TestAccPrivatecaCertificate_privatecaCertificateNoAuthorityExample|TestAccPrivatecaCertificate_privatecaCertificateWithTemplateExample|TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate|TestAccSqlDatabaseInstance_withPrivateNetwork|TestAccSqlUser_postgresIAM You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=218760

…e_is_ca

* Use url_param_only instead of virtual field * Rename new field includeMaxPathLength to includeMaxIssuerPathLength for local consistence

haydentherapper · 2021-11-16T00:59:44Z

mmv1/third_party/terraform/utils/privateca_utils.go

+		flattenPrivatecaCertificateConfigX509ConfigCaOptionsIsCa(val, d, config)
+	// CertificateAuthority does not fields `include_is_ca`.
+	// Expecting non-CertificateAuthority resource does not have field `certificate_authority_id` at top level.
+	if exists && d.Get("certificate_authority_id") == nil {


@slevenick Do you have any suggestions for another way of checking if include_is_ca is present in the schema before setting it?

I would recommend splitting the flatten methods if the schemas no longer match.

This has been solved by adding include_is_ca to the other schema.

modular-magician · 2021-11-16T01:05:40Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 337 insertions(+), 1179 deletions(-))
Terraform Beta: Diff ( 10 files changed, 337 insertions(+), 1179 deletions(-))
TF Validator: Diff ( 3 files changed, 39 insertions(+), 1173 deletions(-))
TF OiCS: Diff ( 2 files changed, 3 insertions(+))

modular-magician · 2021-11-16T18:09:14Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 337 insertions(+), 1179 deletions(-))
Terraform Beta: Diff ( 10 files changed, 337 insertions(+), 1179 deletions(-))
TF Validator: Diff ( 3 files changed, 39 insertions(+), 1173 deletions(-))
TF OiCS: Diff ( 2 files changed, 3 insertions(+))

slevenick

Functionality seems to work correctly. Just need to fix the descriptions on the fields that will appear in docs

slevenick · 2021-12-04T01:02:59Z

mmv1/products/privateca/api.yaml

+                    name: 'nonCa'
+                    url_param_only: true
+                    description: |
+                      Must be set to true when is_ca is set to false.


These descriptions are incorrect now. It would be helpful to include information about why a user would want to use these fields, and what it actually does on the resource it creates.

Hey @slevenick , descriptions are updated to improve the usability.

In order to handle the case of optional primitive fields, I've added virtual fields to allow the expander to distinguish between an unset primitive and a primitive set to the default value. Since some Private CA resources do not support updates, I also added support for setting ForceNew in the terraform config.

This prevents incompatiable configs that set the allow* booleans without setting basic constraints, and vice versa.

…e_is_ca

`include_max_issuer_path_path` to reflect its current functionality * Add field `include_is_ca` to CertificateAuthority to avoding checking the existence of this field in flattener. * Update examples with new fields like `include_is_ca`, `include_max_issuer_path_length`.

changes. * User `nonCa`, `zeroMaxIssuerPathLength` instead of `includeIsCa` `includeMaxIssuerPathLength` * Update test cases.

Run rebase to pull changes from upstream

modular-magician · 2021-12-06T20:01:08Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 463 insertions(+), 1183 deletions(-))
Terraform Beta: Diff ( 11 files changed, 481 insertions(+), 1201 deletions(-))
TF Validator: Diff ( 3 files changed, 39 insertions(+), 1173 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+))

modular-magician · 2021-12-06T21:51:35Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccContainerClusterDatasource_zonal|TestAccContainerClusterDatasource_regional|TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccContainerCluster_basic|TestAccContainerCluster_misc|TestAccContainerCluster_withAddons|TestAccContainerCluster_withILBSubsetting|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withNotificationConfig|TestAccContainerCluster_withReleaseChannelEnabled|TestAccContainerCluster_withNetworkPolicyEnabled|TestAccContainerCluster_withTelemetryEnabled|TestAccContainerCluster_withMasterAuthorizedNetworksConfig|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccContainerCluster_regionalWithNodePool|TestAccContainerCluster_withIntraNodeVisibility|TestAccContainerCluster_withVersion|TestAccContainerCluster_updateVersion|TestAccContainerCluster_network|TestAccContainerCluster_withNodePoolBasic|TestAccContainerCluster_backend|TestAccContainerCluster_withNodePoolResize|TestAccContainerCluster_withNodePoolUpdateVersion|TestAccContainerCluster_withNodePoolAutoscaling|TestAccContainerCluster_withNodePoolMultiple|TestAccContainerCluster_withNodePoolNodeConfig|TestAccContainerCluster_withRecurringMaintenanceWindow|TestAccContainerCluster_withMaintenanceWindow|TestAccContainerCluster_withMaintenanceExclusionWindow|TestAccContainerCluster_nodeAutoprovisioning|TestAccContainerCluster_withShieldedNodes|TestAccContainerCluster_errorAutopilotLocation|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerCluster_withWorkloadIdentityConfig|TestAccContainerCluster_withAutoscalingProfile|TestAccContainerCluster_nodeAutoprovisioningDefaultsMinCpuPlatform|TestAccContainerCluster_withBinaryAuthorization|TestAccContainerCluster_errorNoClusterCreated|TestAccContainerCluster_withDatabaseEncryption|TestAccContainerCluster_withResourceUsageExportConfig|TestAccContainerCluster_withEnableKubernetesAlpha|TestAccContainerNodePool_basicWithClusterId|TestAccContainerNodePool_basic|TestAccContainerNodePool_withNodeConfig|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccContainerNodePool_withSandboxConfig|TestAccContainerNodePool_withKubeletConfig|TestAccContainerNodePool_withLinuxNodeConfig|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccContainerNodePool_withManagement|TestAccContainerNodePool_withNodeConfigScopeAlias|TestAccContainerNodePool_withGPU|TestAccContainerNodePool_regionalAutoscaling|TestAccContainerNodePool_autoscaling|TestAccContainerNodePool_resize|TestAccContainerNodePool_regionalClusters|TestAccContainerNodePool_version|TestAccContainerNodePool_EmptyGuestAccelerator|TestAccContainerNodePool_shieldedInstanceConfig|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerNodePool_ephemeralStorageConfig|TestAccGKEHubMembership_gkehubMembershipIssuerExample|TestAccGKEHubMembership_gkehubMembershipBasicExample|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate|TestAccPrivatecaCertificate_privatecaCertificateNoAuthorityExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=228374

modular-magician · 2021-12-06T23:12:04Z

Tests failed during RECORDING mode: TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccContainerCluster_backend|TestAccContainerCluster_errorAutopilotLocation|TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccPrivatecaCertificate_privatecaCertificateNoAuthorityExample Please fix these to complete your PR

Update doc-string for fields in CaOptions

modular-magician · 2021-12-07T00:50:32Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 506 insertions(+), 1220 deletions(-))
Terraform Beta: Diff ( 10 files changed, 506 insertions(+), 1220 deletions(-))
TF Validator: Diff ( 3 files changed, 39 insertions(+), 1173 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+))

gfxcc · 2021-12-07T23:24:29Z

TestAccPrivatecaCertificate_privatecaCertificateNoAuthorityExample

The failed test was passed when running locally.

slevenick

LGTM! Thanks

* Create custom expander for X509Config In order to handle the case of optional primitive fields, I've added virtual fields to allow the expander to distinguish between an unset primitive and a primitive set to the default value. Since some Private CA resources do not support updates, I also added support for setting ForceNew in the terraform config. * Add error handling for expansion This prevents incompatiable configs that set the allow* booleans without setting basic constraints, and vice versa. * Change virtual field names, and other feedback * Update examples with virtual fields * Use url_param_only instead of virtual field. * Handle CertificateAuthority resource which does not have field include_is_ca * Fix format issue * * Update description for fields `include_is_ca` `include_max_issuer_path_path` to reflect its current functionality * Add field `include_is_ca` to CertificateAuthority to avoding checking the existence of this field in flattener. * Update examples with new fields like `include_is_ca`, `include_max_issuer_path_length`. * Update description; Add test cases for CaOption * fix a typo * remove include_x from template resource * Update semantic meaning for newly added fields to avoid breaking changes. * User `nonCa`, `zeroMaxIssuerPathLength` instead of `includeIsCa` `includeMaxIssuerPathLength` * Update test cases. * Create custom expander for X509Config In order to handle the case of optional primitive fields, I've added virtual fields to allow the expander to distinguish between an unset primitive and a primitive set to the default value. Since some Private CA resources do not support updates, I also added support for setting ForceNew in the terraform config. * Add error handling for expansion This prevents incompatiable configs that set the allow* booleans without setting basic constraints, and vice versa. * Change virtual field names, and other feedback * Update examples with virtual fields * Use url_param_only instead of virtual field. * Handle CertificateAuthority resource which does not have field include_is_ca * Fix format issue * * Update description for fields `include_is_ca` `include_max_issuer_path_path` to reflect its current functionality * Add field `include_is_ca` to CertificateAuthority to avoding checking the existence of this field in flattener. * Update examples with new fields like `include_is_ca`, `include_max_issuer_path_length`. * Update description; Add test cases for CaOption * fix a typo * remove include_x from template resource * Update semantic meaning for newly added fields to avoid breaking changes. * User `nonCa`, `zeroMaxIssuerPathLength` instead of `includeIsCa` `includeMaxIssuerPathLength` * Update test cases. * Update doc-string for fields in CaOptions Co-authored-by: Yong Cao <[email protected]>

google-cla bot added the cla: yes label Oct 25, 2021

modular-magician requested a review from c2thorn October 25, 2021 23:26

rileykarson requested review from slevenick and removed request for c2thorn October 26, 2021 17:08

slevenick requested changes Oct 26, 2021

View reviewed changes

pmansour reviewed Oct 26, 2021

View reviewed changes

haydentherapper requested a review from slevenick October 29, 2021 20:31

gfxcc reviewed Nov 9, 2021

View reviewed changes

mmv1/products/privateca/terraform.yaml Outdated Show resolved Hide resolved

slevenick reviewed Nov 9, 2021

View reviewed changes

haydentherapper added 4 commits November 15, 2021 13:51

Add error handling for expansion

9f159fb

This prevents incompatiable configs that set the allow* booleans without setting basic constraints, and vice versa.

Change virtual field names, and other feedback

da59b02

Update examples with virtual fields

8d5d884

haydentherapper force-pushed the master branch from 19b06e6 to 8d5d884 Compare November 15, 2021 21:55

Use url_param_only instead of virtual field.

5667448

gfxcc and others added 2 commits November 15, 2021 19:23

Handle CertificateAuthority resource which does not have field includ…

7b13b06

…e_is_ca

Merge pull request #1 from gfxcc/rebase_hayden_for_url_param_only

6b8fa35

* Use url_param_only instead of virtual field * Rename new field includeMaxPathLength to includeMaxIssuerPathLength for local consistence

haydentherapper requested a review from slevenick November 16, 2021 00:57

haydentherapper commented Nov 16, 2021

View reviewed changes

Fix format issue

822586c

slevenick reviewed Dec 4, 2021

View reviewed changes

haydentherapper and others added 13 commits December 6, 2021 14:31

Add error handling for expansion

678b9e3

This prevents incompatiable configs that set the allow* booleans without setting basic constraints, and vice versa.

Change virtual field names, and other feedback

93ab41d

Update examples with virtual fields

1cae0c7

Use url_param_only instead of virtual field.

3ec86e2

Handle CertificateAuthority resource which does not have field includ…

33c3d7e

…e_is_ca

Fix format issue

c1294a1

Update description; Add test cases for CaOption

8e901b4

fix a typo

45b2620

remove include_x from template resource

99cc0ef

Update semantic meaning for newly added fields to avoid breaking

f1d5499

changes. * User `nonCa`, `zeroMaxIssuerPathLength` instead of `includeIsCa` `includeMaxIssuerPathLength` * Update test cases.

Merge pull request #6 from gfxcc/rebase_hayden_for_url_param_only

fb9c0f5

Run rebase to pull changes from upstream

gfxcc added 2 commits December 6, 2021 19:36

Update doc-string for fields in CaOptions

efda131

Merge pull request #7 from gfxcc/rebase_hayden_for_url_param_only

4afa1dd

Update doc-string for fields in CaOptions

slevenick self-requested a review December 7, 2021 00:50

slevenick approved these changes Dec 8, 2021

View reviewed changes

slevenick merged commit 0fc925e into GoogleCloudPlatform:master Dec 8, 2021

gfxcc mentioned this pull request Sep 22, 2022

Support non_ca, zero_max_issuer_path_length on CAS resources GoogleCloudPlatform/k8s-config-connector#712

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Private CA - Create expander for X509Config #5368

Private CA - Create expander for X509Config #5368

haydentherapper commented Oct 25, 2021 •

edited by slevenick

Loading

modular-magician commented Oct 25, 2021

modular-magician commented Oct 25, 2021

slevenick Oct 26, 2021

pmansour Oct 26, 2021

slevenick Oct 27, 2021

haydentherapper Oct 28, 2021

slevenick Nov 9, 2021

haydentherapper Nov 16, 2021

pmansour left a comment

pmansour Oct 26, 2021

haydentherapper commented Oct 29, 2021

haydentherapper commented Oct 29, 2021

modular-magician commented Oct 29, 2021

modular-magician commented Oct 29, 2021

slevenick Nov 9, 2021

modular-magician commented Nov 15, 2021

modular-magician commented Nov 15, 2021

haydentherapper Nov 16, 2021

slevenick Nov 16, 2021

haydentherapper Nov 18, 2021

modular-magician commented Nov 16, 2021

modular-magician commented Nov 16, 2021

slevenick left a comment

slevenick Dec 4, 2021

gfxcc Dec 7, 2021

modular-magician commented Dec 6, 2021

modular-magician commented Dec 6, 2021

modular-magician commented Dec 6, 2021

modular-magician commented Dec 7, 2021

gfxcc commented Dec 7, 2021

slevenick left a comment

Private CA - Create expander for X509Config #5368

Private CA - Create expander for X509Config #5368

Conversation

haydentherapper commented Oct 25, 2021 • edited by slevenick Loading

modular-magician commented Oct 25, 2021

modular-magician commented Oct 25, 2021

Diff report:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pmansour left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

haydentherapper commented Oct 29, 2021

haydentherapper commented Oct 29, 2021

modular-magician commented Oct 29, 2021

Diff report:

modular-magician commented Oct 29, 2021

Diff report:

Choose a reason for hiding this comment

modular-magician commented Nov 15, 2021

Diff report:

modular-magician commented Nov 15, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

modular-magician commented Nov 16, 2021

Diff report:

modular-magician commented Nov 16, 2021

Diff report:

slevenick left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

modular-magician commented Dec 6, 2021

Diff report:

modular-magician commented Dec 6, 2021

modular-magician commented Dec 6, 2021

modular-magician commented Dec 7, 2021

Diff report:

gfxcc commented Dec 7, 2021

slevenick left a comment

Choose a reason for hiding this comment

haydentherapper commented Oct 25, 2021 •

edited by slevenick

Loading