-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add streamingConifg.filter to updateMask #5311
Conversation
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=210255 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be best if we had a new test that would have failed before this change, but I can at least say this definitely seems right!
Yup! Right as I was leaving yesterday I thought - I probably should have added a new test there. I'll do that this morning. Thanks! |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccSecurityCenterNotificationConfig_updateStreamingConfigFilter You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=210427 |
Tests failed during RECORDING mode: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic Please fix these to complete your PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
failure clearly unrelated, i've seen it on a few PRs so far - weird.
Fixes hashicorp/terraform-provider-google#10302
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)