Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add streamingConifg.filter to updateMask #5311

Merged
merged 2 commits into from
Oct 13, 2021

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Oct 12, 2021

Fixes hashicorp/terraform-provider-google#10302

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

securitycenter: fixed bug where `google_scc_notification_config.streaming_config.filter` was not updating.

@google-cla google-cla bot added the cla: yes label Oct 12, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Terraform Beta: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=210255

@megan07 megan07 requested a review from nat-henderson October 12, 2021 21:05
Copy link
Contributor

@nat-henderson nat-henderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be best if we had a new test that would have failed before this change, but I can at least say this definitely seems right!

@megan07
Copy link
Contributor Author

megan07 commented Oct 13, 2021

Yup! Right as I was leaving yesterday I thought - I probably should have added a new test there. I'll do that this morning. Thanks!

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 62 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 2 files changed, 62 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccSecurityCenterNotificationConfig_updateStreamingConfigFilter You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=210427

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic Please fix these to complete your PR

Copy link
Contributor

@nat-henderson nat-henderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failure clearly unrelated, i've seen it on a few PRs so far - weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SCC notification_config fails on an update to filter property
3 participants