-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Container_cluster: enables GKE workload metrics #5292
Container_cluster: enables GKE workload metrics #5292
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @c2thorn, please review this PR or find an appropriate assignee. |
Hrm, I guess this should be beta only. I'll fix that |
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @ScottSuarez, please review this PR or find an appropriate assignee. |
7567724
to
49a150e
Compare
49a150e
to
88a0d9d
Compare
I was able to tweak the generated files for beta/ga, but couldn't figure out how to gate the docs. If someone could point me towards that, I will fix it. |
@geojaz doc files themselves are not versioned, we just notate a beta-only field with a simple |
mmv1/third_party/terraform/website/docs/r/container_cluster.html.markdown
Outdated
Show resolved
Hide resolved
…ml.markdown Co-authored-by: Scott Suarez <[email protected]>
/gcbrun |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccComputeRouterPeer_advertiseMode You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=210243 |
I'm unable to see the failure, if someone will let me know what needs to be fixed, i'll give it a shot. |
As per https://cloud.google.com/blog/products/operations/managed-metric-collection-for-google-kubernetes-engine
GKE workload metrics are available in beta.
This updates the schema so that
WORKLOAD
is an allowed value formonitoring_config
This fixes hashicorp/terraform-provider-google#10275
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)