Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added send_empty_value to is_ca field to force sending false #5274

Closed
wants to merge 1 commit into from

Conversation

melinath
Copy link
Member

@melinath melinath commented Oct 4, 2021

Resolved hashicorp/terraform-provider-google#10239 by ensuring that the Terraform value will be used as expected.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

privateca: Fixed bug where `is_ca` could not be set to false for google_privateca_ca_pool

@melinath melinath requested a review from slevenick October 4, 2021 20:32
@google-cla google-cla bot added the cla: yes label Oct 4, 2021
@modular-magician

This comment has been minimized.

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need this on other boolean fields in these resources if the API treats them all in the same way?

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 5 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 6 files changed, 6 insertions(+), 6 deletions(-))
TF Conversion: Diff ( 3 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@melinath
Copy link
Member Author

melinath commented Oct 4, 2021

@slevenick The other impacted bool fields (allow_subject_passthrough & allow_subject_alt_names_passthrough) are already send_empty_value: true

@melinath melinath requested a review from slevenick October 4, 2021 22:29
@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccPrivatecaCaPool_privatecaCapoolAllFieldsExample|TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline|TestAccPrivatecaCertificate_privatecaCertificateConfigExample|TestAccPrivatecaCertificate_privatecaCertificateNoAuthorityExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=208993

@melinath
Copy link
Member Author

Leaving this to be fixed in a different way.

@melinath melinath closed this Oct 13, 2021
@melinath melinath deleted the tpg-10239 branch October 13, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants