Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Osconfig resource (alpha) #5266

Merged
merged 7 commits into from
Oct 5, 2021

Conversation

slevenick
Copy link
Contributor

@slevenick slevenick commented Sep 30, 2021

Necessary changes for OSConfig Assignment resource at alpha. Includes a change that makes empty arrays send to the DCL as empty arrays specifically rather than nil, which correctly causes them to be set to empty.

Also includes some fixes for acronym-ized resource names like OSConfig

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@google-cla google-cla bot added the cla: yes label Sep 30, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 26 insertions(+), 26 deletions(-))
Terraform Beta: Diff ( 11 files changed, 40 insertions(+), 40 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleGlobalForwardingRule|TestAccAssuredWorkloadsWorkload_BasicHandWritten|TestAccAssuredWorkloadsWorkload_FullHandWritten|TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccComputeGlobalForwardingRule_updateTarget|TestAccComputeGlobalForwardingRule_ipv6|TestAccComputeGlobalForwardingRule_labels|TestAccComputeForwardingRule_update|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccDataprocWorkflowTemplate_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=208625

@slevenick slevenick requested a review from rileykarson October 1, 2021 23:17
@rileykarson rileykarson changed the title Osconfig resource Osconfig resource (alpha) Oct 4, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 26 insertions(+), 26 deletions(-))
Terraform Beta: Diff ( 11 files changed, 40 insertions(+), 40 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 26 insertions(+), 26 deletions(-))
Terraform Beta: Diff ( 11 files changed, 40 insertions(+), 40 deletions(-))

@slevenick
Copy link
Contributor Author

All related tests passed in REPLAYING mode

@slevenick slevenick merged commit a0343e2 into GoogleCloudPlatform:master Oct 5, 2021
khajduczenia pushed a commit to khajduczenia/magic-modules that referenced this pull request Oct 12, 2021
* Adding private compile

* Send empty array instead of nil for non-computed arrays

* Revert serialize cmd change

* Remove extra logs, revert go mod and sum

* Revert go sum changes

* Delegate DCL version switching to function

* Fix extra slash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants