-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Osconfig resource (alpha) #5266
Osconfig resource (alpha) #5266
Conversation
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleGlobalForwardingRule|TestAccAssuredWorkloadsWorkload_BasicHandWritten|TestAccAssuredWorkloadsWorkload_FullHandWritten|TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccComputeGlobalForwardingRule_updateTarget|TestAccComputeGlobalForwardingRule_ipv6|TestAccComputeGlobalForwardingRule_labels|TestAccComputeForwardingRule_update|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccDataprocWorkflowTemplate_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=208625 |
mmv1/third_party/terraform/tests/resource_gke_hub_feature_membership_test.go.erb
Outdated
Show resolved
Hide resolved
41ed5a4
to
5525a4b
Compare
All related tests passed in REPLAYING mode |
* Adding private compile * Send empty array instead of nil for non-computed arrays * Revert serialize cmd change * Remove extra logs, revert go mod and sum * Revert go sum changes * Delegate DCL version switching to function * Fix extra slash
Necessary changes for OSConfig Assignment resource at alpha. Includes a change that makes empty arrays send to the DCL as empty arrays specifically rather than nil, which correctly causes them to be set to empty.
Also includes some fixes for acronym-ized resource names like OSConfig
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)