-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added storage bucket datasource #5251
Added storage bucket datasource #5251
Conversation
maybe the VCR tests timed out? |
/gcbrun |
mmv1/third_party/terraform/data_sources/data_source_google_storage_bucket.go
Show resolved
Hide resolved
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleStorageBucket_basic|TestAccComputeForwardingRule_update You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=208304 |
Watch out for the test / lint checks prior to merging! VCR failing for no good reason has definitely given me a bad habit of dismissing red checks- I think one of the files needs a |
Thanks for pointing it out! Working on it. |
Added you on #5255, running |
Thanks! |
* addeed storage bucket datasource * fix typo
This resolves hashicorp/terraform-provider-google#5311
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)