Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added storage bucket datasource #5251

Merged

Conversation

shuyama1
Copy link
Member

This resolves hashicorp/terraform-provider-google#5311

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_storage_bucket`

@shuyama1 shuyama1 requested a review from c2thorn September 28, 2021 18:55
@google-cla google-cla bot added the cla: yes label Sep 28, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 107 insertions(+))
Terraform Beta: Diff ( 7 files changed, 110 insertions(+), 2 deletions(-))

@shuyama1 shuyama1 changed the title Addeed storage bucket datasource Added storage bucket datasource Sep 28, 2021
@c2thorn
Copy link
Member

c2thorn commented Sep 29, 2021

maybe the VCR tests timed out?

@c2thorn
Copy link
Member

c2thorn commented Sep 29, 2021

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 107 insertions(+))
Terraform Beta: Diff ( 5 files changed, 107 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleStorageBucket_basic|TestAccComputeForwardingRule_update You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=208304

@rileykarson
Copy link
Member

Watch out for the test / lint checks prior to merging! VCR failing for no good reason has definitely given me a bad habit of dismissing red checks- I think one of the files needs a make fmt is all.

@shuyama1
Copy link
Member Author

Thanks for pointing it out! Working on it.

@rileykarson
Copy link
Member

Added you on #5255, running gofmt -w mmv1/third_party/terraform/tests/data_source_google_storage_bucket_test.go it took to fix. Just a picky linter!

@shuyama1
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a data entry for google_storage_bucket
4 participants