Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure the sweeper to clean up firewall rules that are leftover #5202

Merged
merged 3 commits into from
Sep 14, 2021
Merged

configure the sweeper to clean up firewall rules that are leftover #5202

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ebc3a7
configure the sweeper to clean up firewall rules that are leftover fr…
ScottSuarez Sep 14, 2021
7c0aad2
add information on which test is being skipped
ScottSuarez Sep 14, 2021
35e7e49
Update gcp_sweeper_test.go
ScottSuarez Sep 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions mmv1/third_party/terraform/tests/resource_google_project_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,7 @@ func skipIfEnvNotSet(t *testing.T, envs ...string) {

for _, k := range envs {
if os.Getenv(k) == "" {
log.Printf("[DEBUG] Warning - environment variable %s is not set - skipping test %s", k, t.Name())
t.Skipf("Environment variable %s is not set", k)
}
}
Expand Down
1 change: 1 addition & 0 deletions mmv1/third_party/terraform/utils/gcp_sweeper_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ var testResourcePrefixes = []string{
"df-", // https://github.com/hashicorp/terraform-provider-google/issues/8909
"resourcegroup-", // https://github.com/hashicorp/terraform-provider-google/issues/8924
"cluster-", // https://github.com/hashicorp/terraform-provider-google/issues/8924
"k8s-fw-",
ScottSuarez marked this conversation as resolved.
Show resolved Hide resolved
}

func TestMain(m *testing.M) {
Expand Down