Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestAccStorageSignedUrl_accTest #5200

Merged
merged 8 commits into from
Sep 15, 2021
Merged

Fix TestAccStorageSignedUrl_accTest #5200

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0c14bf6
allow disabling service accounts
upodroid Sep 2, 2021
ef105d3
fix typos
upodroid Sep 2, 2021
6b89411
revert warning change
upodroid Sep 7, 2021
c02428a
Merge branch 'master' of github.com:GoogleCloudPlatform/magic-modules
upodroid Sep 14, 2021
482e03e
remove dynamically generated header from test
upodroid Sep 14, 2021
bfc895c
reinstance the test with a diff header
upodroid Sep 14, 2021
6bc6426
fix typo
upodroid Sep 15, 2021
c665c64
fix fmt
upodroid Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions mmv1/third_party/terraform/tests/data_source_storage_object_signed_url_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,8 @@ func TestAccStorageSignedUrl_accTest(t *testing.T) {
bucketName := fmt.Sprintf("tf-test-bucket-%d", randInt(t))

headers := map[string]string{
"x-goog-test": "foo",
"x-goog-if-generation-match": "1",
"x-goog-test": "foo",
"x-goog-if-metageneration-match": "1",
}

vcrTest(t, resource.TestCase{
Expand Down Expand Up @@ -248,7 +248,7 @@ data "google_storage_object_signed_url" "story_url_w_headers" {
path = google_storage_bucket_object.story.name
extension_headers = {
x-goog-test = "foo"
x-goog-if-generation-match = 1
x-goog-if-metageneration-match = 1
}
}

Expand Down