Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle scenarios where the dcl resource can't be found on READ #5166

Merged

Conversation

ScottSuarez
Copy link
Contributor

@ScottSuarez ScottSuarez commented Sep 2, 2021

closes hashicorp/terraform-provider-google#9904

Release Note Template for Downstream PRs (will be copied)

eventarc: fixed bug where resources could not be deleted out of bounds

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 35 insertions(+), 21 deletions(-))
Terraform Beta: Diff ( 11 files changed, 41 insertions(+), 30 deletions(-))

@ScottSuarez
Copy link
Contributor Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 36 insertions(+), 22 deletions(-))
Terraform Beta: Diff ( 11 files changed, 41 insertions(+), 30 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceSecretManagerSecret_basic|TestAccComputeOrganizationSecurityPolicyRule_organizationSecurityPolicyRuleBasicExample|TestAccComputeOrganizationSecurityPolicyAssociation_organizationSecurityPolicyAssociationBasicExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccFirebaseWebApp_firebaseWebAppBasicExample|TestAccOSConfigGuestPolicies_osConfigGuestPoliciesBasicExample|TestAccOSConfigGuestPolicies_osConfigGuestPoliciesPackagesExample|TestAccOSConfigGuestPolicies_osConfigGuestPoliciesRecipesExample|TestAccVPCAccessConnector_vpcAccessConnectorSharedVPCExample|TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=204042

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccOSConfigGuestPolicies_osConfigGuestPoliciesRecipesExample|TestAccOSConfigGuestPolicies_osConfigGuestPoliciesPackagesExample|TestAccOSConfigGuestPolicies_osConfigGuestPoliciesBasicExample|TestAccComputeOrganizationSecurityPolicyAssociation_organizationSecurityPolicyAssociationBasicExample|TestAccFirebaseWebApp_firebaseWebAppBasicExample Please fix these to complete your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_eventarc_trigger errors if deleted out-of-band
3 participants