Compute instance reservation affinity

[edwardsamuel]

Add reservationAffinity field into Instances and InstanceTemplates.

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added `reservation_affinity` field to `google_compute_instance` resource
compute: added `reservation_affinity` field to `google_compute_instance_template` resource

[modular-magician]

Oops! It looks like you're using an unknown release-note type in your changelog entries:

• REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@melinath, please review this PR or find an appropriate assignee.

[modular-magician]

Hi! I'm the modular magician. Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

[melinath]

Unfortunately, Instance and ComputeInstance are both handwritten resources for terraform (and we don't generate any other tools from Magic Modules) so you would need to make changes to the handwritten resources, tests, and docs.

For example, here's the compute instance resource: https://github.com/GoogleCloudPlatform/magic-modules/blob/master/mmv1/third_party/terraform/resources/resource_compute_instance.go.erb

[edwardsamuel]

Hi @melinath, it looks like the reservation_affinity for google_compute_instance and google_compute_instance_template is available for Terraform as in #4335. My initial intention is to make it available to Ansible as well. Generated code: edwardsamuel/google.cloud@314bebe.

Do we need to have a manual edit on resources/tests/docs for Ansible?

[melinath]

@rambleraptor you might know what to do here.

[edwardsamuel]

Would be appreciated if someone can give some directions on how to update the Ansible module.

As per my understanding, https://github.com/ansible-collections/google.cloud committers is modular-magician only. We can backtrack the changes/PRs to this repo.

[melinath]

@rambleraptor do you have any insight on this?

[edwardsamuel]

Any idea how to move forward the changes?

[edwardsamuel]

I saw there was a manual update: adding private_network to gcp_sql_instance (ansible-collections/google.cloud#451) and merged by @rambleraptor.

Is my assumption correct: we don't maintain Ansible via this magic-module anymore, but we can submit a PR directly to the https://github.com/ansible-collections/google.cloud/?
cc @melinath

[rambleraptor]

I think that would be the best course of action.

[melinath]

Closing this as the question is resolved