Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send empty log_config value #5154

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Aug 30, 2021

Fixes hashicorp/terraform-provider-google#9943

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: fixed an issue in `google_compute_router_nat` where removing `log_config` resulted in a perma-diff

@google-cla google-cla bot added the cla: yes label Aug 30, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 95 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 95 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeRouterNat_removeLogConfig|TestAccComputeRouterNat_withManualIpAndSubnetConfiguration|TestAccComputeRouterNat_withDisabledIndependentEndpointMapping|TestAccComputeRouterNat_withNatIpsAndDrainNatIps|TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=203500

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline Please fix these to complete your PR

@c2thorn c2thorn requested review from a team and nat-henderson and removed request for a team August 31, 2021 15:54
@c2thorn c2thorn merged commit a9af7f4 into GoogleCloudPlatform:master Aug 31, 2021
@c2thorn c2thorn deleted the remove-log-config branch August 31, 2021 18:53
khajduczenia pushed a commit to khajduczenia/magic-modules that referenced this pull request Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing compute router nat log_config results in perma-diff
3 participants