-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upstream 9723 #5112
upstream 9723 #5112
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComposerEnvironment_update|TestAccComposerEnvironment_withSoftwareConfig|TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline|TestAccSqlDatabaseInstance_multipleOperations|TestAccSqlUser_postgres|TestAccSqlUser_postgresIAM|TestAccSqlUser_postgresAbandon You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=201931 |
Tests failed during RECORDING mode: TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline|TestAccComposerEnvironment_withSoftwareConfig|TestAccComposerEnvironment_update Please fix these to complete your PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can postgres have a users based on emails? I thought that was mysql only
I'm not super familiar, but based on the reported issue, and here, it says to enter the email address for CLOUD_IAM_USERs. https://cloud.google.com/sql/docs/postgres/create-manage-users#console_1 |
* Fix:9723 google_sql_user - "Root resource was present, but now absent" * Moved the declaration closer to the usage * Fetching the instance data Co-authored-by: Josh Angolano <[email protected]>
Upstreams hashicorp/terraform-provider-google#9848 (review)
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)