Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstream 9723 #5112

Merged
merged 3 commits into from
Aug 19, 2021
Merged

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Aug 19, 2021

Upstreams hashicorp/terraform-provider-google#9848 (review)

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

sql: fixed bug in `google_sql_user` with CLOUD_IAM_USERs on POSTGRES.

@google-cla
Copy link

google-cla bot commented Aug 19, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Aug 19, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 8 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 9 insertions(+), 3 deletions(-))

@megan07 megan07 changed the title Megan upstream 9723 upstream 9723 Aug 19, 2021
@megan07 megan07 requested a review from slevenick August 19, 2021 15:32
@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComposerEnvironment_update|TestAccComposerEnvironment_withSoftwareConfig|TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline|TestAccSqlDatabaseInstance_multipleOperations|TestAccSqlUser_postgres|TestAccSqlUser_postgresIAM|TestAccSqlUser_postgresAbandon You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=201931

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline|TestAccComposerEnvironment_withSoftwareConfig|TestAccComposerEnvironment_update Please fix these to complete your PR

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can postgres have a users based on emails? I thought that was mysql only

@megan07
Copy link
Contributor Author

megan07 commented Aug 19, 2021

I'm not super familiar, but based on the reported issue, and here, it says to enter the email address for CLOUD_IAM_USERs. https://cloud.google.com/sql/docs/postgres/create-manage-users#console_1

@megan07 megan07 merged commit 5d537f0 into GoogleCloudPlatform:master Aug 19, 2021
khajduczenia pushed a commit to khajduczenia/magic-modules that referenced this pull request Oct 12, 2021
* Fix:9723 google_sql_user - "Root resource was present, but now absent"

* Moved the declaration closer to the usage

* Fetching the instance data

Co-authored-by: Josh Angolano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants