Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote google_essential_contacts_contact to GA #5097

Merged

Conversation

upodroid
Copy link
Contributor

Fixes: hashicorp/terraform-provider-google#9783

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

essentialcontacts: promoted `google_essential_contacts_contact` to GA

Co-authored-by: upodroid <[email protected]>
@google-cla google-cla bot added the cla: yes label Aug 16, 2021
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ScottSuarez, please review this PR or find an appropriate assignee.

@upodroid
Copy link
Contributor Author

upodroid commented Aug 16, 2021

@c2thorn

The import_format is a bit tricky.

2021/08/16 19:43:44 [DEBUG] matching ID projects/REDACTED/contacts/4 to regex (?P<parent>[^/]+)/contacts.
2021/08/16 19:43:44 [DEBUG] importing parent = REDACTED
2021/08/16 19:43:44 [WARN] Got error running Terraform: exit status 1

Error: nil entry in ImportState results. This is always a bug with
the resource that is being imported. Please report this as
a bug to Terraform.


    provider_test.go:270: Step 2/2 error running import: exit status 1
        
        Error: nil entry in ImportState results. This is always a bug with
        the resource that is being imported. Please report this as
        a bug to Terraform.
        

import format should be {{parent}}/contacts/{{contact_id}} except contact_id doesn't exist and {{parent}} is various selflinks for orgs,folders and projects :(

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 576 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 3 files changed, 22 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 2 files changed, 78 insertions(+))
TF OiCS: Diff ( 1 file changed, 2 deletions(-))

@ScottSuarez
Copy link
Contributor

Try doing this instead of adding contactId.

It should work.

@upodroid
Copy link
Contributor Author

thanks, it worked

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 576 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 4 files changed, 24 insertions(+), 9 deletions(-))
TF Conversion: Diff ( 2 files changed, 78 insertions(+))
TF OiCS: Diff ( 1 file changed, 2 deletions(-))

@ScottSuarez ScottSuarez self-requested a review August 16, 2021 20:37
@ScottSuarez ScottSuarez self-requested a review August 16, 2021 20:38
@ScottSuarez
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 561 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 6 files changed, 13 insertions(+), 12 deletions(-))
TF Conversion: Diff ( 2 files changed, 78 insertions(+))
TF OiCS: Diff ( 1 file changed, 2 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 561 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 6 files changed, 12 insertions(+), 12 deletions(-))
TF Conversion: Diff ( 2 files changed, 78 insertions(+))
TF OiCS: Diff ( 1 file changed, 2 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccEssentialContactsContact_essentialContactExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=201383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix import for google_essential_contacts_contact
3 participants