Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L3 default support for Network Load Balancer #5059

Merged
merged 2 commits into from
Aug 12, 2021

Conversation

drebes
Copy link
Member

@drebes drebes commented Aug 8, 2021

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added support for `L3_DEFAULT` as `ip_protocol` for `google_compute_forwarding_rule` and `UNSPECIFIED` as `protocol` for `google_compute_region_backend_service` to support network load balancers that forward all protocols and ports.

@drebes drebes requested a review from rileykarson August 8, 2021 08:50
@google-cla google-cla bot added the cla: yes label Aug 8, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 42 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 5 files changed, 92 insertions(+), 6 deletions(-))
Ansible: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 4 files changed, 127 insertions(+))
Inspec: Diff ( 2 files changed, 2 insertions(+))

@rileykarson
Copy link
Member

/gcbrun

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question, running VCR to get test results otherwise

mmv1/products/compute/api.yaml Show resolved Hide resolved
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 42 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 7 files changed, 94 insertions(+), 9 deletions(-))
TF OiCS: Diff ( 4 files changed, 127 insertions(+))

@modular-magician
Copy link
Collaborator

Error trying to cancel build ()

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeForwardingRule_forwardingRuleL3DefaultExampleTestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=200697

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM (ignore the VCR failure, I superseded it w/ a manual run)

Just waiting on resolution re: descriptions to merge

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 75 insertions(+), 31 deletions(-))
Terraform Beta: Diff ( 6 files changed, 126 insertions(+), 31 deletions(-))
TF OiCS: Diff ( 4 files changed, 127 insertions(+))

@modular-magician
Copy link
Collaborator

Error trying to cancel build ()

1 similar comment
@modular-magician
Copy link
Collaborator

Error trying to cancel build ()

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeForwardingRule_forwardingRuleL3DefaultExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=200888

@rileykarson
Copy link
Member

Not sure what's up w/ the test failure, iam.go didn't import sort for no good reason. Ignoring that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants