-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L3 default support for Network Load Balancer #5059
Conversation
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 4 files changed, 42 insertions(+), 6 deletions(-)) |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small question, running VCR to get test results otherwise
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 4 files changed, 42 insertions(+), 6 deletions(-)) |
Error trying to cancel build () |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeForwardingRule_forwardingRuleL3DefaultExampleTestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=200697 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM (ignore the VCR failure, I superseded it w/ a manual run)
Just waiting on resolution re: descriptions to merge
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 5 files changed, 75 insertions(+), 31 deletions(-)) |
Error trying to cancel build () |
1 similar comment
Error trying to cancel build () |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeForwardingRule_forwardingRuleL3DefaultExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=200888 |
Not sure what's up w/ the test failure, |
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)