fixed diff in publishing_options

[edwardmedia]

Fixes hashicorp/terraform-provider-google#9675

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

privateca: fixed a permadiff bug for `publishing_options` on `google_privateca_ca_pool` when both attributes set false

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@slevenick, please review this PR or find an appropriate assignee.

[melinath]

/gcbrun okay CI should actually be fixed now - built image off the wrong commit last time.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 49 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 2 files changed, 49 insertions(+), 6 deletions(-))
TF Conversion: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

[slevenick]

/gcbrun CI failed with OOM

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 49 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 2 files changed, 49 insertions(+), 6 deletions(-))
TF Conversion: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplateBasicExample|TestAccDialogflowCXVersion_dialogflowcxVersionFullExample|TestAccDialogflowCXVersion_update|TestAccPrivatecaCaPool_privatecaCapoolEmptyPublishingOptions|TestAccPrivatecaCaPool_privatecaCapoolAllFieldsExample|TestAccPrivatecaCaPool_privatecaCapoolUpdate|TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=199976

[modular-magician]

Tests failed during RECORDING mode: TestAccPrivatecaCaPool_privatecaCapoolAllFieldsExample|TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline|TestAccPrivatecaCaPool_privatecaCapoolUpdate Please fix these to complete your PR

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 49 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 3 files changed, 50 insertions(+), 8 deletions(-))
TF Conversion: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

[modular-magician]

Error trying to cancel build ()

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccPrivatecaCaPool_privatecaCapoolUpdate|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccPrivatecaCaPool_privatecaCapoolAllFieldsExample|TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=200683

[modular-magician]

Tests failed during RECORDING mode: TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline|TestAccPrivatecaCaPool_privatecaCapoolUpdate|TestAccPrivatecaCaPool_privatecaCapoolAllFieldsExample Please fix these to complete your PR

[slevenick]

@edwardmedia can you rebase off of master? I believe the remaining privateca issues have been fixed now

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 49 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 3 files changed, 50 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

[modular-magician]

Error trying to cancel build ()

[modular-magician]

Error trying to cancel build ()

[slevenick]

/gcbrun

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 49 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 3 files changed, 50 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeInstanceFromMachineImage_basic|TestAccComputeInstanceFromMachineImage_overrideMetadataDotStartupScript|TestAccPrivatecaCaPool_privatecaCapoolAllFieldsExample|TestAccPrivatecaCaPool_privatecaCapoolUpdate|TestAccPrivatecaCertificate_privatecaCertificateWithTemplateExample|TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=202990

[modular-magician]

Tests failed during RECORDING mode: TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline Please fix these to complete your PR

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 47 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 5 files changed, 51 insertions(+), 7 deletions(-))

[slevenick]

Wait, why did you just remove the send_if_empty on those fields?

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccPrivatecaCaPool_privatecaCapoolAllFieldsExample|TestAccPrivatecaCaPool_privatecaCapoolUpdate|TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=203010

[modular-magician]

Tests failed during RECORDING mode: TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline Please fix these to complete your PR

[slevenick]

Thanks!