-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix composer environment version regexp #5039
Fix composer environment version regexp #5039
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @rileykarson, please review this PR or find an appropriate assignee. |
Do you mind rebasing? Sorry, seems there's been a flake in CI that should be resolved by taking in #5038 |
This shouldn't require rebasing - /gcbrun should be enough |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
/gcbrun |
Sorry for the delay in getting back! I need to declare an email bankruptcy, or something. |
Fixed environment version regexp to explicitly require
.
(dot) instead of any character afterpreview
literal.Example:
composer-2.0.0-preview.0-airflow-2.1.1
.part of hashicorp/terraform-provider-google#9611
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)