resource_storage_bucket_object: added support for Customer Supplied E…

[jaceq]

…ncryption Keys (CSEK)

As per title, added support for customer supplied encryption keys.

This resolves: hashicorp/terraform-provider-google#8133
This is a follow up (as per advice from @ScottSuarez ) of: #4950

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

added support for Customer Supplied Encryption Key (CSEK)

[modular-magician]

Oops! It looks like you're using an unknown release-note type in your changelog entries:

• enhancement added support for Customer Supplied Encryption Key (CSEK)

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@slevenick, please review this PR or find an appropriate assignee.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 108 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 2 files changed, 108 insertions(+), 13 deletions(-))

[slevenick]

@ScottSuarez I think you have context on this, can you take a look?

[ScottSuarez]

Whenever you submit your changes are are ready for another review hit the little re-request review button next to my name. ^^

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 141 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 2 files changed, 141 insertions(+), 13 deletions(-))

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 141 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 2 files changed, 141 insertions(+), 13 deletions(-))

[ScottSuarez]

Last bit of asks ! Thanks for your help :)

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 135 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 2 files changed, 135 insertions(+), 1 deletion(-))

[ScottSuarez]

/gcbrun

[ScottSuarez]

oh! one more thing, sorry, could you add this field to the documentation for this resource?

https://github.com/GoogleCloudPlatform/magic-modules/blob/master/mmv1/third_party/terraform/website/docs/r/storage_bucket_object.html.markdown

To see how we usually document nested fields check here.
https://github.com/hashicorp/terraform-provider-google/blob/master/website/docs/r/compute_instance.html.markdown

after this these changes should be good to go pending tests pass!

Thanks so much for your help :)

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 135 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 2 files changed, 135 insertions(+), 1 deletion(-))

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 146 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 146 insertions(+), 1 deletion(-))

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 146 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 5 files changed, 149 insertions(+), 3 deletions(-))

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 146 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 4 files changed, 147 insertions(+), 2 deletions(-))

[jaceq]

@ScottSuarez I've added documentation entries as requested.

[ScottSuarez]

/gcbrun

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 146 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 4 files changed, 147 insertions(+), 2 deletions(-))

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudbuildWorkerPool_basic|TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplateBasicExample|TestAccStorageObject_customerEncryption You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=199300

[modular-magician]

Tests failed during RECORDING mode: TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplateBasicExample|TestAccCloudbuildWorkerPool_basic Please fix these to complete your PR

[ScottSuarez]

test passed ! this is good to go !

Checked in ~. should release next Monday :]