-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed pubsublite update issues #4954
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @c2thorn, please review this PR or find an appropriate assignee. |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccContainerNodePool_withGPU You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=195339 |
Tests failed during RECORDING mode: TestAccContainerNodePool_withGPU Please fix these to complete your PR |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccContainerNodePool_withGPU|TestAccPubsubLiteSubscription_pubsubLiteSubscription_deliveryRequirement_update|TestAccPubsubLiteTopic_pubsubLiteTopic_count_update You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=195435 |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 8 files changed, 148 insertions(+), 34 deletions(-)) |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccBigqueryDataTransferConfig|TestAccComputeBackendService_backendServiceNetworkEndpointExample|TestAccComputeBackendService_withBackend|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeBackendService_withBackendAndMaxUtilization|TestAccComputeBackendService_withMaxConnections|TestAccComputeBackendService_withMaxConnectionsPerInstance|TestAccComputeBackendService_withMaxRatePerEndpoint|TestAccComputeBackendService_withMaxConnectionsPerEndpoint|TestAccComputeBackendService_regionNegBackend|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeInstanceGroup_rename|TestAccContainerCluster_backend|TestAccContainerNodePool_withGPU|TestAccTags You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=195511 |
Tests failed during RECORDING mode: TestAccComputeBackendService_regionNegBackend|TestAccComputeBackendService_withMaxRatePerEndpoint|TestAccComputeBackendService_backendServiceNetworkEndpointExample|TestAccBigqueryDataTransferConfig|TestAccComputeBackendService_withMaxConnectionsPerEndpoint|TestAccComputeBackendService_withBackend|TestAccComputeBackendService_withMaxConnections|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeBackendService_withMaxConnectionsPerInstance|TestAccComputeBackendService_withBackendAndMaxUtilization|TestAccComputeInstanceGroup_rename|TestAccContainerCluster_backend|TestAccContainerNodePool_withGPU Please fix these to complete your PR |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming the new tests pass
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccAssuredWorkloadsWorkload_basic|TestAccAssuredWorkloadsWorkload_full|TestAccBigqueryDataTransferConfig|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccContainerNodePool_withGPU|TestAccPrivatecaCertificate_privatecaCertificateCsrExample|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityBasicExample|TestAccPrivatecaCertificate_privatecaCertificateConfigExample|TestAccPrivatecaCertificate_privatecaCertificateNoAuthorityExample|TestAccTags You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=195862 |
Tests failed during RECORDING mode: TestAccAssuredWorkloadsWorkload_full|TestAccAssuredWorkloadsWorkload_basic|TestAccContainerNodePool_withGPU Please fix these to complete your PR |
* fixed pubsublite update issues * add tests
Fixes hashicorp/terraform-provider-google#9511
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)