Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource : google_dialogflow_cx_intent #4948

Merged
merged 4 commits into from
Jul 9, 2021

Conversation

jcanizalez
Copy link
Contributor

Fixes hashicorp/terraform-provider-google#9498

Replace each [ ] with [X] to check it. Switch to the preview view to make it easier to click on links.
These steps will speed up the review process, and we appreciate you spending time on them before sending
your code to be reviewed.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_dialogflow_cx_intent`

@google-cla google-cla bot added the cla: yes label Jul 2, 2021
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@c2thorn, please review this PR or find an appropriate assignee.

@modular-magician modular-magician requested a review from c2thorn July 2, 2021 15:56
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 1314 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 8 files changed, 1315 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 2 files changed, 254 insertions(+), 1 deletion(-))
TF OiCS: Diff ( 4 files changed, 148 insertions(+))

@jcanizalez jcanizalez requested a review from c2thorn July 8, 2021 15:12
@jcanizalez
Copy link
Contributor Author

hi @c2thorn
Thanks for your review I applied your suggestions, so you can take a look when you got time

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 1333 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 9 files changed, 1335 insertions(+), 6 deletions(-))
TF Conversion: Diff ( 2 files changed, 264 insertions(+), 1 deletion(-))
TF OiCS: Diff ( 4 files changed, 148 insertions(+))

@c2thorn
Copy link
Member

c2thorn commented Jul 8, 2021

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 1333 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 7 files changed, 1333 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 2 files changed, 264 insertions(+), 1 deletion(-))
TF OiCS: Diff ( 4 files changed, 148 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccContainerNodePool_withGPU|TestAccDialogflowCXIntent_dialogflowcxIntentFullExample|TestAccDialogflowCXAgent_dialogflowcxAgentFullExample|TestAccDialogflowCXIntent_update|TestAccDialogflowCXAgent_update You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=195672

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccContainerNodePool_withGPU Please fix these to complete your PR

@jcanizalez
Copy link
Contributor Author

hi @c2thorn could you share me please what is the error in the failing test TestAccContainerNodePool_withGPU.

Thanks

@c2thorn
Copy link
Member

c2thorn commented Jul 8, 2021

@jcanizalez I am confident that the failure is unrelated. Your tests look good. Our downstream builder seems to have a few hiccups at the moment, but this PR looks good and should be ready to merge once I get the okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support to deploy Intents in DialogFlow CX
3 participants