-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource : google_dialogflow_cx_intent
#4948
New Resource : google_dialogflow_cx_intent
#4948
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @c2thorn, please review this PR or find an appropriate assignee. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 7 files changed, 1314 insertions(+), 3 deletions(-)) |
mmv1/third_party/terraform/tests/resource_dialogflowcx_intent_test.go.erb
Outdated
Show resolved
Hide resolved
hi @c2thorn |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 7 files changed, 1333 insertions(+), 3 deletions(-)) |
/gcbrun |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 7 files changed, 1333 insertions(+), 3 deletions(-)) |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccContainerNodePool_withGPU|TestAccDialogflowCXIntent_dialogflowcxIntentFullExample|TestAccDialogflowCXAgent_dialogflowcxAgentFullExample|TestAccDialogflowCXIntent_update|TestAccDialogflowCXAgent_update You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=195672 |
Tests failed during RECORDING mode: TestAccContainerNodePool_withGPU Please fix these to complete your PR |
hi @c2thorn could you share me please what is the error in the failing test TestAccContainerNodePool_withGPU. Thanks |
@jcanizalez I am confident that the failure is unrelated. Your tests look good. Our downstream builder seems to have a few hiccups at the moment, but this PR looks good and should be ready to merge once I get the okay. |
Fixes hashicorp/terraform-provider-google#9498
Replace each [ ] with [X] to check it. Switch to the preview view to make it easier to click on links.
These steps will speed up the review process, and we appreciate you spending time on them before sending
your code to be reviewed.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)