Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made billing budget amount updatable #4929

Merged
merged 2 commits into from
Jun 29, 2021

Conversation

melinath
Copy link
Member

@melinath melinath commented Jun 29, 2021

Billing budget amount was not actually getting updated. Resolved hashicorp/terraform-provider-google#9440

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

billing: made `amount.specified_amount.units` updatable on `google_billing_budget`

@google-cla google-cla bot added the cla: yes label Jun 29, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 48 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 2 files changed, 49 insertions(+), 6 deletions(-))

@melinath melinath requested review from a team and slevenick and removed request for a team June 29, 2021 18:16
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 51 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 2 files changed, 51 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccBillingBudget_billingBudgetUpdate|TestAccContainerNodePool_withGPU You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=194281

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccContainerNodePool_withGPU Please fix these to complete your PR

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccBillingBudget_billingBudgetUpdate|TestAccContainerNodePool_withGPU You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=194284

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccContainerNodePool_withGPU Please fix these to complete your PR

@melinath
Copy link
Member Author

Test failure is unrelated.

@melinath melinath merged commit e0b159c into GoogleCloudPlatform:master Jun 29, 2021
melinath added a commit to melinath/magic-modules that referenced this pull request Jun 30, 2021
This is a follow-up for GoogleCloudPlatform#4929, which fixed this issue for `amount` and its subfields
melinath added a commit that referenced this pull request Jun 30, 2021
)

This is a follow-up for #4929, which fixed this issue for `amount` and its subfields
modular-magician added a commit to modular-magician/terraform-provider-google-beta that referenced this pull request Jun 30, 2021
…shicorp#4933)

This is a follow-up for GoogleCloudPlatform/magic-modules#4929, which fixed this issue for `amount` and its subfields

Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this pull request Jun 30, 2021
…shicorp#4933)

This is a follow-up for GoogleCloudPlatform/magic-modules#4929, which fixed this issue for `amount` and its subfields

Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit to hashicorp/terraform-provider-google that referenced this pull request Jun 30, 2021
) (#9473)

This is a follow-up for GoogleCloudPlatform/magic-modules#4929, which fixed this issue for `amount` and its subfields

Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit to hashicorp/terraform-provider-google-beta that referenced this pull request Jun 30, 2021
) (#3394)

This is a follow-up for GoogleCloudPlatform/magic-modules#4929, which fixed this issue for `amount` and its subfields

Signed-off-by: Modular Magician <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_billing_budget: Can not update the budget amount
3 participants