New Resource : `google_dialogflowcx_entity_type` #4924

jcanizalez · 2021-06-28T14:32:33Z

Hi team,

Fixes hashicorp/terraform-provider-google#9451

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_dialogflow_cx_entity_type`

modular-magician · 2021-06-28T14:34:10Z

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@slevenick, please review this PR or find an appropriate assignee.

modular-magician · 2021-06-28T14:43:09Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 1061 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 7 files changed, 1062 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 1 file changed, 169 insertions(+))
TF OiCS: Diff ( 4 files changed, 132 insertions(+))

…-modules into entitycx

modular-magician · 2021-07-01T22:15:49Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 1035 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 7 files changed, 1035 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 2 files changed, 170 insertions(+), 1 deletion(-))
TF OiCS: Diff ( 4 files changed, 131 insertions(+))

modular-magician · 2021-07-01T22:21:17Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 1035 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 8 files changed, 1037 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 2 files changed, 170 insertions(+), 1 deletion(-))
TF OiCS: Diff ( 4 files changed, 131 insertions(+))

…-modules into entitycx

jcanizalez · 2021-07-09T16:12:13Z

hi @slevenick could you help me please reviewing this PR?

Thanks

modular-magician · 2021-07-09T16:19:46Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 1034 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 1034 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 169 insertions(+))
TF OiCS: Diff ( 4 files changed, 131 insertions(+))

…-modules into entitycx

modular-magician · 2021-07-12T22:02:48Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 1034 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 1034 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 169 insertions(+))
TF OiCS: Diff ( 4 files changed, 131 insertions(+))

…-modules into entitycx

modular-magician · 2021-07-13T20:27:44Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 1034 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 1034 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 169 insertions(+))
TF OiCS: Diff ( 4 files changed, 131 insertions(+))

slevenick

Seems reasonable, I'll run tests and check back

/gcbrun

mmv1/products/dialogflowcx/api.yaml

mmv1/third_party/terraform/tests/resource_dialogflowcx_entity_type_test.go.erb

modular-magician · 2021-07-24T00:37:31Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 1035 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 1035 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 169 insertions(+))
TF OiCS: Diff ( 4 files changed, 131 insertions(+))

mmv1/third_party/terraform/tests/resource_dialogflowcx_entity_type_test.go

slevenick

/gcbrun

Seems reasonable, just a little spacing issue

slevenick · 2021-07-30T16:32:23Z

/gcbrun

modular-magician · 2021-07-30T16:43:37Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 1035 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 1035 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 169 insertions(+))
TF OiCS: Diff ( 4 files changed, 131 insertions(+))

modular-magician · 2021-07-30T18:11:53Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccAssuredWorkloadsWorkload_basic|TestAccAssuredWorkloadsWorkload_full|TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplateBasicExample|TestAccDataprocWorkflowTemplate_basic|TestAccDialogflowCXEntityType_dialogflowcxEntityTypeFullExample|TestAccDialogflowCXEntityType_update|TestAccGKEHubMembership_gkehubMembershipBasicExample|TestAccGKEHubMembership_gkehubMembershipIssuerExample|TestAccNetworkServicesEdgeCacheOrigin_updateAndImport|TestAccNetworkServicesEdgeCacheService_networkServicesEdgeCacheServiceAdvancedExample|TestAccPrivatecaCertificate_privatecaCertificateNoAuthorityExample|TestAccSecurityCenterNotificationConfig_sccNotificationConfigBasicExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=198988

modular-magician · 2021-07-30T18:38:35Z

Tests failed during RECORDING mode: TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplateBasicExample|TestAccPrivatecaCertificate_privatecaCertificateNoAuthorityExample Please fix these to complete your PR

slevenick · 2021-08-03T00:17:35Z

Ok, sorry i've been slow on this. If you can fix the merge conflicts I'll do a final test run and then merge assuming it's looking good!

…-modules into entitycx

jcanizalez · 2021-08-03T16:47:54Z

Thanks @slevenick I resolved the conflicts

slevenick · 2021-08-03T16:51:09Z

/gcbrun

modular-magician · 2021-08-03T16:52:57Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 1035 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 7 files changed, 1036 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 1 file changed, 169 insertions(+))
TF OiCS: Diff ( 4 files changed, 131 insertions(+))

modular-magician · 2021-08-03T16:58:20Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 1035 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 1035 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 169 insertions(+))
TF OiCS: Diff ( 4 files changed, 131 insertions(+))

modular-magician · 2021-08-03T17:02:24Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 1035 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 1035 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 169 insertions(+))
TF OiCS: Diff ( 4 files changed, 131 insertions(+))

slevenick

Thanks!

…#4924) * Including API definition for EntityType * Including acc tests for EntityTypes * Adding example for Dialogflow entity type * Refactoring with suggestions made in PR for versions * Updated Entity Type tests * Fix space in tests

jcanizalez added 3 commits June 24, 2021 10:00

Including API definition for EntityType

fd5ce34

Including acc tests for EntityTypes

557f9ff

Adding example for Dialogflow entity type

8c2f4a8

google-cla bot added the cla: yes label Jun 28, 2021

modular-magician requested a review from slevenick June 28, 2021 14:34

jcanizalez added 2 commits July 1, 2021 11:38

Merge branch 'master' of https://github.com/GoogleCloudPlatform/magic…

65fc246

…-modules into entitycx

Refactoring with suggestions made in PR for versions

a4d1b01

jcanizalez force-pushed the entitycx branch from 21112a4 to a4d1b01 Compare July 1, 2021 22:10

Merge branch 'master' of https://github.com/GoogleCloudPlatform/magic…

7b54df0

…-modules into entitycx

Merge branch 'master' of https://github.com/GoogleCloudPlatform/magic…

516f15d

…-modules into entitycx

Merge branch 'master' of https://github.com/GoogleCloudPlatform/magic…

34f4124

…-modules into entitycx

slevenick reviewed Jul 15, 2021

View reviewed changes

mmv1/products/dialogflowcx/api.yaml Show resolved Hide resolved

jcanizalez requested a review from slevenick July 20, 2021 23:59

slevenick reviewed Jul 23, 2021

View reviewed changes

mmv1/third_party/terraform/tests/resource_dialogflowcx_entity_type_test.go.erb Outdated Show resolved Hide resolved

Updated Entity Type tests

cb8fbb9

jcanizalez requested a review from slevenick July 24, 2021 00:27

slevenick reviewed Jul 30, 2021

View reviewed changes

mmv1/third_party/terraform/tests/resource_dialogflowcx_entity_type_test.go Outdated Show resolved Hide resolved

slevenick reviewed Jul 30, 2021

View reviewed changes

jcanizalez added 2 commits August 3, 2021 10:41

Merge branch 'master' of https://github.com/GoogleCloudPlatform/magic…

824a8c1

…-modules into entitycx

Fix space in tests

9f1f2b5

jcanizalez requested a review from slevenick August 3, 2021 16:47

slevenick approved these changes Aug 4, 2021

View reviewed changes

slevenick merged commit 7620513 into GoogleCloudPlatform:master Aug 4, 2021

jcanizalez deleted the entitycx branch August 18, 2021 17:28

jcanizalez restored the entitycx branch August 18, 2021 17:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource : `google_dialogflowcx_entity_type` #4924

New Resource : `google_dialogflowcx_entity_type` #4924

jcanizalez commented Jun 28, 2021

modular-magician commented Jun 28, 2021

modular-magician commented Jun 28, 2021

modular-magician commented Jul 1, 2021

modular-magician commented Jul 1, 2021

jcanizalez commented Jul 9, 2021

modular-magician commented Jul 9, 2021

modular-magician commented Jul 12, 2021

modular-magician commented Jul 13, 2021

slevenick left a comment

modular-magician commented Jul 24, 2021

slevenick left a comment

slevenick commented Jul 30, 2021

modular-magician commented Jul 30, 2021

modular-magician commented Jul 30, 2021

modular-magician commented Jul 30, 2021

slevenick commented Aug 3, 2021

jcanizalez commented Aug 3, 2021 •

edited

Loading

slevenick commented Aug 3, 2021

modular-magician commented Aug 3, 2021

modular-magician commented Aug 3, 2021

modular-magician commented Aug 3, 2021

slevenick left a comment

New Resource : google_dialogflowcx_entity_type #4924

New Resource : google_dialogflowcx_entity_type #4924

Conversation

jcanizalez commented Jun 28, 2021

modular-magician commented Jun 28, 2021

modular-magician commented Jun 28, 2021

Diff report:

modular-magician commented Jul 1, 2021

Diff report:

modular-magician commented Jul 1, 2021

Diff report:

jcanizalez commented Jul 9, 2021

modular-magician commented Jul 9, 2021

Diff report:

modular-magician commented Jul 12, 2021

Diff report:

modular-magician commented Jul 13, 2021

Diff report:

slevenick left a comment

Choose a reason for hiding this comment

modular-magician commented Jul 24, 2021

Diff report:

slevenick left a comment

Choose a reason for hiding this comment

slevenick commented Jul 30, 2021

modular-magician commented Jul 30, 2021

Diff report:

modular-magician commented Jul 30, 2021

modular-magician commented Jul 30, 2021

slevenick commented Aug 3, 2021

jcanizalez commented Aug 3, 2021 • edited Loading

slevenick commented Aug 3, 2021

modular-magician commented Aug 3, 2021

Diff report:

modular-magician commented Aug 3, 2021

Diff report:

modular-magician commented Aug 3, 2021

Diff report:

slevenick left a comment

Choose a reason for hiding this comment

New Resource : `google_dialogflowcx_entity_type` #4924

New Resource : `google_dialogflowcx_entity_type` #4924

jcanizalez commented Aug 3, 2021 •

edited

Loading