storage_bucket_object: added holds

[jaceq]

Signed-off-by: Jacek Kikiewicz [email protected]

This is a followup from hashicorp/terraform-provider-google#9403 as per request of @ScottSuarez
This closes: hashicorp/terraform-provider-google#6022

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

I haven't been able to ACC tests

Release Note Template for Downstream PRs (will be copied)

storage_bucket_object: added temporary_hold and event_based_hold attributes

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

[jaceq]

@googlebot I signed it!

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 76 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 2 files changed, 76 insertions(+), 1 deletion(-))

[ScottSuarez]

/gcbrun

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 76 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 4 files changed, 78 insertions(+), 4 deletions(-))

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudbuildWorkerPool_withNetwork|TestAccContainerNodePool_withGPU|TestAccEventarcTrigger_basic|TestAccEventarcTrigger_transport|TestAccStorageObject_holds You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=193725

[modular-magician]

Tests failed during RECORDING mode: TestAccStorageObject_holds|TestAccCloudbuildWorkerPool_withNetwork|TestAccContainerNodePool_withGPU Please fix these to complete your PR

[ScottSuarez]

Looks like the test in failing in ci

=== RUN   TestAccStorageObject_holds
=== PAUSE TestAccStorageObject_holds
=== CONT  TestAccStorageObject_holds
    testing_new.go:63: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: Error deleting contents of object tf-gce-test: googleapi: Error 403: Object 'tf-test-bucket-2404561034928499575/tf-gce-test' is under active Temporary hold and cannot be deleted, overwritten or archived until hold is removed., forbidden
        
        
--- FAIL: TestAccStorageObject_holds (7.85s)

perhaps you will need to set deletion protection to false on the bucket and add another step where you take the hold off the object, yes?

[jaceq]

@ScottSuarez thx for input.
This is a bit tricky though, at the moment resource_storage_bucket_object.go has no updates... so holds are 'ForceNew' this means that in reality there so now way to take them away by updating in any way...
What do you suggest in this case? Shall I look into extending bucket object with update call? (I guess otherwise it won't work)

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 123 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 124 insertions(+), 2 deletions(-))

[jaceq]

Ok, so I added Update function and set holds as update able.
I also managed to run ACC tests (well only for holds) this time and now they are green, overall test is:

• creating object with holds
• updating object to remove holds

[ScottSuarez]

everything looks good to me aside from that one comment pending tests pass

[c2thorn]

Hi @jaceq
We changed our CI recently, so in order to get the tests going, this will need to be rebased off of the latest commit of master. Sorry about this.

[ScottSuarez]

/gcbrun .. I pulled master for them ^^

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 121 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 122 insertions(+), 2 deletions(-))

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 121 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 122 insertions(+), 2 deletions(-))

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeInstance_advancedMachineFeatures|TestAccComputeInstance_updateRunning_desiredStatusNotSet_notAllowStoppingForUpdate|TestAccComputeInstance_updateRunning_desiredStatusRunning_notAllowStoppingForUpdate|TestAccContainerNodePool_withGPU|TestAccStorageObject_holds You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=194484

[modular-magician]

Tests failed during RECORDING mode: TestAccComputeInstance_updateRunning_desiredStatusRunning_notAllowStoppingForUpdate|TestAccComputeInstance_updateRunning_desiredStatusNotSet_notAllowStoppingForUpdate|TestAccContainerNodePool_withGPU Please fix these to complete your PR

[jaceq]

@ScottSuarez sorry, I am confused a bit, is there still something for me to do (rebase) or not?

[ScottSuarez]

nope you are good to go! Thanks for the contribution @jaceq ^^