Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mtls refactor for endpoints #4869

Merged
merged 17 commits into from
Jun 16, 2021
Merged

Conversation

ScottSuarez
Copy link
Contributor

@ScottSuarez ScottSuarez commented Jun 14, 2021

added support for mtls authentication

Release Note Template for Downstream PRs (will be copied)

added support for [mtls authentication](https://google.aip.dev/auth/4114) 

ref: go/dca:terraform

@ScottSuarez ScottSuarez requested a review from slevenick June 14, 2021 17:24
@google-cla google-cla bot added the cla: yes label Jun 14, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 302 insertions(+), 238 deletions(-))
Terraform Beta: Diff ( 5 files changed, 338 insertions(+), 274 deletions(-))
TF Conversion: Diff ( 2 files changed, 169 insertions(+), 177 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192082"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 305 insertions(+), 239 deletions(-))
Terraform Beta: Diff ( 5 files changed, 341 insertions(+), 275 deletions(-))
TF Conversion: Diff ( 2 files changed, 172 insertions(+), 178 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192092"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 381 insertions(+), 239 deletions(-))
Terraform Beta: Diff ( 5 files changed, 429 insertions(+), 275 deletions(-))
TF Conversion: Diff ( 2 files changed, 248 insertions(+), 178 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192105"

@ScottSuarez ScottSuarez requested a review from slevenick June 14, 2021 23:01
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 377 insertions(+), 239 deletions(-))
Terraform Beta: Diff ( 5 files changed, 425 insertions(+), 275 deletions(-))
TF Conversion: Diff ( 2 files changed, 248 insertions(+), 178 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192119"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 374 insertions(+), 239 deletions(-))
Terraform Beta: Diff ( 6 files changed, 423 insertions(+), 276 deletions(-))
TF Conversion: Diff ( 2 files changed, 248 insertions(+), 178 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192121"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 387 insertions(+), 239 deletions(-))
Terraform Beta: Diff ( 7 files changed, 436 insertions(+), 276 deletions(-))
TF Conversion: Diff ( 2 files changed, 248 insertions(+), 178 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192201"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 387 insertions(+), 239 deletions(-))
Terraform Beta: Diff ( 7 files changed, 436 insertions(+), 276 deletions(-))
TF Conversion: Diff ( 2 files changed, 248 insertions(+), 178 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192204"

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will this work for DCL-based resources?

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 492 insertions(+), 334 deletions(-))
Terraform Beta: Diff ( 9 files changed, 556 insertions(+), 385 deletions(-))
TF Conversion: Diff ( 2 files changed, 350 insertions(+), 273 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192205"

@ScottSuarez ScottSuarez requested a review from slevenick June 15, 2021 23:20
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 393 insertions(+), 241 deletions(-))
Terraform Beta: Diff ( 7 files changed, 441 insertions(+), 277 deletions(-))
TF Conversion: Diff ( 2 files changed, 251 insertions(+), 180 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192210"

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fix for eventarc base path

mmv1/third_party/terraform/utils/config.go.erb Outdated Show resolved Hide resolved
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 391 insertions(+), 241 deletions(-))
Terraform Beta: Diff ( 8 files changed, 440 insertions(+), 278 deletions(-))
TF Conversion: Diff ( 2 files changed, 249 insertions(+), 180 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192303"

@ScottSuarez
Copy link
Contributor Author

test passed on previous run.. merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants