Generate Filestore in Terraform in Magic Modules. #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit c9ebc85) have been included in your existing downstream PRs. |
# This is the 1st commit message: Generate Filestore in Terraform in Magic Modules. Two significant magic modules changes here: * This change adds the new parameter setting 'url_param_only', which suppresses the value in the body of HTTP requests. This is necessary in new-style products, where /location/ is used instead of zone or region. * This change fixes an issue with 'ignore_read', which previously only worked on top-level fields. With this change, nested fields also are not set on read if marked 'ignore_read'. Both of these are implemented in terraform only. # This is the commit message #2: remove YAGNI problem / make rubocop happy.
nat-henderson
force-pushed
the
filestore
branch
from
11d5891 to
97de1d8
Compare
|
Terraform's not going to compile on this one - That's because there's some work that needs to be done to swap |
rambleraptor
approved these changes
Sep 22, 2018
Tracked submodules are build/puppet/_bundle build/puppet/auth build/puppet/bigquery build/puppet/compute build/puppet/sql build/puppet/storage build/puppet/spanner build/puppet/container build/puppet/dns build/puppet/pubsub build/puppet/resourcemanager build/chef/_bundle build/chef/auth build/chef/compute build/chef/sql build/chef/storage build/chef/spanner build/chef/container build/chef/dns build/chef/iam build/terraform build/ansible.
|
Hey @ndmckinley did we lose the test code somewhere here? It's in Terraform but isn't in MM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three significant magic modules changes here:
This change adds the new parameter setting 'url_param_only',
which suppresses the value in the body of HTTP requests. This is
necessary in new-style products, where /location/ is used instead
of zone or region.
This change fixes an issue with 'ignore_read', which previously
only worked on top-level fields. With this change, nested fields
also are not set on read if marked 'ignore_read'.
Both of these are implemented in terraform only.
That's implemented in all providers.
[all]
Minor changes associated with implementing Filestore Instance in Terraform.
[terraform]
Implement Filestore Instance.