Add app_engine_service_network_settings resource

[matty-rose]

Fixes: hashicorp/terraform-provider-google#7866

Reference: https://cloud.google.com/appengine/docs/admin-api/reference/rest/v1/apps.services#networksettings

I'm not sure whether I need to write more tests for this resource, on top of the generated example one - some other resources seem to only have the generated example test and I couldn't really see a distinction between those had extra tests and those that didn't.

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_app_engine_service_network_settings`

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@c2thorn, please review this PR or find an appropriate assignee.

[matty-rose]

Hey @c2thorn any chance you'll be able to have a look at this soon? I'm not sure what the failing CI checks are

[c2thorn]

Hey @matty-rose sorry for the delay and thanks for the ping. The error seems to come from failed Inspec generation, would you mind trying excluding the resource from Inspec like in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/mmv1/products/dataproc/inspec.yaml

[matty-rose]

@c2thorn made that change but CI still doesn't seem to be happy

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 563 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 563 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 83 insertions(+))
TF OiCS: Diff ( 4 files changed, 136 insertions(+))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=191298"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccAppEngineServiceNetworkSettings_appEngineServiceNetworkSettingsExample|TestAccEventarcTrigger_transport You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=191331"

[c2thorn]

Seems good for the most part, just a couple of questions I want to follow up on. Regarding your first post about testing - one other test we often do is a handwritten one that tests updating every field that is updatable. There aren't a lot of fields here, so it doesn't seem like a big deal. But I would encourage you to at least have tried updating the fields manually if you haven't already.

[c2thorn]

Is this something that is updatable without recreating the resource?

[matty-rose]

I think technically yes? since the API call the terraform resource makes is only a PATCH - This is another one I took from the SplitTraffic resource since they are very similar, but not really sure on the correct behaviour here

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 698 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 7 files changed, 699 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 1 file changed, 83 insertions(+))
TF OiCS: Diff ( 4 files changed, 136 insertions(+))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=191701"

[c2thorn]

/gcbrun

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192076"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 698 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 7 files changed, 699 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 1 file changed, 83 insertions(+))
TF OiCS: Diff ( 4 files changed, 136 insertions(+))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192077"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccAppEngineServiceNetworkSettings_update You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192083"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccAppEngineServiceNetworkSettings_update You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192083"

[matty-rose]

any insights on these test failures @c2thorn?

[c2thorn]

The check was faulty, the tests actually passed! LGTM, I'll get this merged in.

[matty-rose]

thanks for your assistance @c2thorn !