Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow api gateway to change #4782

Merged
merged 2 commits into from
May 13, 2021
Merged

allow api gateway to change #4782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ff4c45
allow api gateway to change
ScottSuarez May 12, 2021
c47093a
add note for changing api_configs
ScottSuarez May 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions mmv1/products/apigateway/api.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ objects:
required: true
description: |
Google Cloud IAM service account used to sign OIDC tokens for backends that have authentication configured
(https://cloud.google.com/service-infrastructure/docs/service-management/reference/rest/v1/services.configs#backend).
(https://cloud.google.com/service-infrastructure/docs/service-management/reference/rest/v1/services.configs#backend).
- !ruby/object:Api::Type::Array
name: 'openapiDocuments'
description: |
Expand Down Expand Up @@ -219,9 +219,9 @@ objects:
- !ruby/object:Api::Type::String
name: 'apiConfig'
required: true
input: true
description: |
Resource name of the API Config for this Gateway. Format: projects/{project}/locations/global/apis/{api}/configs/{apiConfig}
Resource name of the API Config for this Gateway. Format: projects/{project}/locations/global/apis/{api}/configs/{apiConfig}.
When changing api configs please ensure the new config is a new resource and the lifecycle rule `create_before_destroy` is set.
- !ruby/object:Api::Type::String
name: 'defaultHostname'
output: true
Expand Down
3 changes: 3 additions & 0 deletions mmv1/third_party/terraform/tests/resource_api_gateway_gateway_test.go.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ resource "google_api_gateway_api_config" "api_gw" {
provider = google-beta
api = google_api_gateway_api.api_gw.api_id
api_config_id = "tf-test-api-gw%{random_suffix}"
lifecycle {
create_before_destroy = true
}

openapi_documents {
document {
Expand Down