-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bigtable CMEK Support #4770
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @c2thorn, please review this PR or find an appropriate assignee. |
Co-authored-by: upodroid <[email protected]>
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=185977" |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=185978" |
/gcbrun |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=187389" |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=187390" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccBigQueryDataTable_bigtable|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=187400" |
Tests failed during RECORDING mode: TestAccBigQueryDataTable_bigtable|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample Please fix these to complete your PR |
Upgrading cloud.google.com/go/bigtable causes the other tests like |
Interesting, I haven't run the other tests 😄 |
They fixed the issue in googleapis/google-cloud-go#4105, I'll wait on next release |
fyi @c2thorn it appears that a release has been made: https://github.com/googleapis/google-cloud-go/releases/tag/bigtable%2Fv1.10.1 |
/gcbrun |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192535" |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192537" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccInstanceTemplateDatasource_filter_mostRecent|TestAccAppEngineStandardAppVersion_update|TestAccBigQueryDataTable_bigtable|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccBinaryAuthorizationPolicy_basic|TestAccBinaryAuthorizationPolicy_full|TestAccBinaryAuthorizationPolicy_separateProject|TestAccCloudRunService_cloudRunServiceSecretEnvironmentVariablesExample|TestAccCloudRunService_cloudRunServiceSecretVolumesExample|TestAccCloudRunService_secretVolume|TestAccBinaryAuthorizationPolicy_update|TestAccCloudRunService_secretEnvironmentVariable|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeBackendBucket_backendBucketFullExample|TestAccComputeBackendBucket_withCdnPolicy|TestAccComputeBackendService_backendServiceCacheSimpleExample|TestAccComputeBackendService_backendServiceCacheExample|TestAccComputeBackendService_withSecurityPolicy|TestAccComputeBackendService_withCdnPolicy|TestAccComputeDiskResourcePolicyAttachment_update|TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample|TestAccComputeRegionBackendService_regionBackendServiceCacheExample|TestAccComputeSecurityPolicy_basic|TestAccComputeSecurityPolicy_withRuleExpr|TestAccComputeSecurityPolicy_withRule|TestAccComputeSecurityPolicy_update|TestAccContainerCluster_withILBSubsetting|TestAccContainerCluster_withNodeConfigScopeAlias|TestAccDataprocClusterIamBinding|TestAccDataprocClusterIamMember|TestAccDataprocClusterIamPolicy|TestAccDataprocCluster_updatable|TestAccDataprocCluster_withConfigOverrides|TestAccDataprocCluster_withTempBucket|TestAccDataprocCluster_withStagingBucket|TestAccDataprocCluster_withInitAction|TestAccDataprocJobIamBinding|TestAccDataprocJobIamMember|TestAccDataprocCluster_withServiceAcc|TestAccDataprocJobIamPolicy|TestAccDataprocJob_updatable|TestAccDataprocJob_PySpark|TestAccDataprocJob_Spark|TestAccDataprocJob_Hadoop|TestAccDataprocJob_Hive|TestAccDataprocJob_Pig|TestAccDataprocJob_SparkSql|TestAccIAMBetaWorkloadIdentityPoolProvider_oidc|TestAccIAMBetaWorkloadIdentityPoolProvider_aws|TestAccRedisInstance_update|TestAccSqlDatabaseInstance_diskspecs|TestAccVPCAccessConnector_vpcAccessConnectorExample|TestAccVPCAccessConnector_vpcAccessConnectorSharedVPCExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192540" |
@@ -36,10 +36,6 @@ func resourceBigtableInstance() *schema.Resource { | |||
}, | |||
}, | |||
|
|||
// ---------------------------------------------------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note:
We are moving ahead with removing this now that deletion_protection
is available.
@@ -82,6 +78,13 @@ func resourceBigtableInstance() *schema.Resource { | |||
ValidateFunc: validation.StringInSlice([]string{"SSD", "HDD"}, false), | |||
Description: `The storage type to use. One of "SSD" or "HDD". Defaults to "SSD".`, | |||
}, | |||
"kms_key_name": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for context:
This field is optional+computed and deletion protection is available. Introducing this as a new ForceNew field should have lower risk than before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests pass after the upstream fix. Requesting some more warnings/notes about the field in documentation, and then we should be good to go.
mmv1/third_party/terraform/website/docs/r/bigtable_instance.html.markdown
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went ahead and committed the documentation add
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=192563" |
thanks |
Fixes: hashicorp/terraform-provider-google#8882
You need to upgrade the bigtable library.
go get -u cloud.google.com/go/bigtable
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)