-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing MM logging to favor debug over info #477
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
example output w/out using the debug flag:
|
100% agree on this. We don't really use the info logs at all. |
rambleraptor
approved these changes
Sep 19, 2018
The INFO logs are getting filled with what looks like debug level information. When compiling 1 product for 1 provider there are 16k INFO statements and zero DEBUG level logs. This makes it difficult to show anything important in the standard logging without escalating to WARN. This change will move most of the output to debug level and set the default logging level to INFO. The -d flag will still show all 16K lines of output but at INFO there will only be a message for what is getting generated and what is going to be excluded. This will require a bit of a paradigm shift for people to start using debug going forward where info was previously used.
chrisst
force-pushed
the
tuning-log-output
branch
from
September 20, 2018 23:34
7e320c5
to
c42b89a
Compare
I am a robot that works on MagicModules PRs! Once this PR is approved, you can feel free to merge it without taking any further steps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The INFO logs are getting filled with what looks like debug level information.
When compiling 1 product for 1 provider there are 16k INFO statements and zero
DEBUG level logs. This makes it difficult to show anything important in the
standard logging without escalating to WARN.
This change will move most of the output to debug level and set the default
logging level to INFO. The -d flag will still show all 16K lines of output but
at INFO there will only be a message for what is getting generated and what is
going to be excluded.
This will require a bit of a paradigm shift for people to start using debug
going forward where info was previously used.
[all]
[terraform]
[puppet]
[puppet-bigquery]
[puppet-compute]
[puppet-container]
[puppet-dns]
[puppet-logging]
[puppet-pubsub]
[puppet-resourcemanager]
[puppet-sql]
[puppet-storage]
[chef]
[chef-compute]
[chef-container]
[chef-dns]
[chef-logging]
[chef-spanner]
[chef-sql]
[chef-storage]
[ansible]