Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conflicts with, node_version only works on the default node pool #4762

Merged

Conversation

slevenick
Copy link
Contributor

Fixes: hashicorp/terraform-provider-google#9021

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: added validation to check that both `node_version` and `remove_default_node_pool` cannot be set on `google_container_cluster`

@google-cla google-cla bot added the cla: yes label May 4, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Terraform Beta: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=185689"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendService_internalLoadBalancing You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=185788"

@slevenick slevenick requested a review from rileykarson May 5, 2021 16:44
Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can do this in a minor version because remove_default_node_pool can be set to false, in which case setting node_version is valid.

@slevenick
Copy link
Contributor Author

I don't think we can do this in a minor version because remove_default_node_pool can be set to false, in which case setting node_version is valid.

Ah right. It would work as a customize diff that checks for true and a node_version set right?

@rileykarson
Copy link
Member

rileykarson commented May 5, 2021 via email

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 9 insertions(+))
Terraform Beta: Diff ( 1 file changed, 9 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=185861"

@slevenick slevenick merged commit 488e1cf into GoogleCloudPlatform:master May 6, 2021
melinath added a commit to GoogleCloudPlatform/terraform-validator that referenced this pull request Jul 20, 2021
Had to update the terraform file for compatibility with GoogleCloudPlatform/magic-modules#4762
melinath added a commit to GoogleCloudPlatform/terraform-validator that referenced this pull request Jul 21, 2021
* Run ReadPlannedAssets tests as part of unit tests

* Fixed full_container_cluster test

Had to update the terraform file for compatibility with GoogleCloudPlatform/magic-modules#4762

* Regenerated full_spanner_instance plan

* Regenerated full_compute_instance plan json

* Removed example_compute_forwarding_rule read test since it can't run in offline mode

* Re-generated example_sql_database_instance tfplan json

* Removed example_compute_instance test

This can't run in offline mode

* Fixed marshalling/unmarshalling of timestamps

* Regenerated project organization policy tfplan json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give a warning (or error) when using remove_default_node_pool and node_version at the same time.
3 participants