-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conflicts with, node_version only works on the default node pool #4762
Add conflicts with, node_version only works on the default node pool #4762
Conversation
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=185689" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendService_internalLoadBalancing You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=185788" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can do this in a minor version because remove_default_node_pool
can be set to false
, in which case setting node_version
is valid.
Ah right. It would work as a customize diff that checks for |
Yep!
…On Wed, May 5, 2021 at 9:57 AM Sam Levenick ***@***.***> wrote:
I don't think we can do this in a minor version because
remove_default_node_pool can be set to false, in which case setting
node_version is valid.
Ah right. It would work as a customize diff that checks for true and a
node_version set right?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#4762 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAP36CC2F5GHB6AVECFU2EDTMF2IRANCNFSM44DSJTJQ>
.
|
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=185861" |
Had to update the terraform file for compatibility with GoogleCloudPlatform/magic-modules#4762
* Run ReadPlannedAssets tests as part of unit tests * Fixed full_container_cluster test Had to update the terraform file for compatibility with GoogleCloudPlatform/magic-modules#4762 * Regenerated full_spanner_instance plan * Regenerated full_compute_instance plan json * Removed example_compute_forwarding_rule read test since it can't run in offline mode * Re-generated example_sql_database_instance tfplan json * Removed example_compute_instance test This can't run in offline mode * Fixed marshalling/unmarshalling of timestamps * Regenerated project organization policy tfplan json
Fixes: hashicorp/terraform-provider-google#9021
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)