Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add initial_size to google_compute_node_group #4750

Merged
merged 11 commits into from
May 5, 2021

Conversation

ScottSuarez
Copy link
Contributor

@ScottSuarez ScottSuarez commented Apr 29, 2021

closes hashicorp/terraform-provider-google#4275

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added `initial_size` to account for scenarios where size may change under the hood in resource `google_compute_node_group`

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 37 insertions(+), 15 deletions(-))
Terraform Beta: Diff ( 3 files changed, 37 insertions(+), 15 deletions(-))
Ansible: Diff ( 2 files changed, 30 insertions(+), 7 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Inspec: Diff ( 4 files changed, 8 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=184946"

@@ -8333,7 +8333,7 @@ objects:
name: 'NodeGroup'
kind: 'compute#NodeGroup'
base_url: projects/{{project}}/zones/{{zone}}/nodeGroups
create_url: projects/{{project}}/zones/{{zone}}/nodeGroups?initialNodeCount={{size}}
create_url: projects/{{project}}/zones/{{zone}}/nodeGroups?initialNodeCount=PRE_CREATE_REPLACE_ME
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll need to make most of these changes in terraform.yaml (any api.yaml property can be used there, it overwrites the api.yaml value) to avoid breaking Ansible / possibly InSpec

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 37 insertions(+), 15 deletions(-))
Terraform Beta: Diff ( 3 files changed, 37 insertions(+), 15 deletions(-))
Ansible: Diff ( 2 files changed, 29 insertions(+), 6 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Inspec: Diff ( 4 files changed, 8 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=185512"

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small extra notes on the .yaml files- seems like InSpec is still generating so let's make sure that is OK.

@slevenick: It seems inspec isn't respecting the include- is that a problem?

mmv1/products/compute/inspec.yaml Outdated Show resolved Hide resolved
mmv1/products/compute/ansible.yaml Outdated Show resolved Hide resolved
mmv1/products/compute/api.yaml Outdated Show resolved Hide resolved
@slevenick
Copy link
Contributor

Couple small extra notes on the .yaml files- seems like InSpec is still generating so let's make sure that is OK.

@slevenick: It seems inspec isn't respecting the include- is that a problem?

Not a big deal

@ScottSuarez
Copy link
Contributor Author

/gcbrun

@ScottSuarez ScottSuarez requested a review from rileykarson May 4, 2021 20:57
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 37 insertions(+), 15 deletions(-))
Terraform Beta: Diff ( 4 files changed, 38 insertions(+), 16 deletions(-))
Ansible: Diff ( 1 file changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=185686"

mmv1/products/compute/api.yaml Show resolved Hide resolved
@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendService_internalLoadBalancing|TestAccComputeNodeGroup_nodeGroupAutoscalingPolicyExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=185688"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 37 insertions(+), 15 deletions(-))
Terraform Beta: Diff ( 3 files changed, 37 insertions(+), 15 deletions(-))
Ansible: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=185787"

@ScottSuarez ScottSuarez merged commit b3e0a99 into GoogleCloudPlatform:master May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to increase number of sole tenant nodes in node group
4 participants