-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add initial_size to google_compute_node_group #4750
add initial_size to google_compute_node_group #4750
Conversation
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 37 insertions(+), 15 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=184946" |
mmv1/products/compute/api.yaml
Outdated
@@ -8333,7 +8333,7 @@ objects: | |||
name: 'NodeGroup' | |||
kind: 'compute#NodeGroup' | |||
base_url: projects/{{project}}/zones/{{zone}}/nodeGroups | |||
create_url: projects/{{project}}/zones/{{zone}}/nodeGroups?initialNodeCount={{size}} | |||
create_url: projects/{{project}}/zones/{{zone}}/nodeGroups?initialNodeCount=PRE_CREATE_REPLACE_ME |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'll need to make most of these changes in terraform.yaml
(any api.yaml property can be used there, it overwrites the api.yaml value) to avoid breaking Ansible / possibly InSpec
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 37 insertions(+), 15 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=185512" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small extra notes on the .yaml files- seems like InSpec is still generating so let's make sure that is OK.
@slevenick: It seems inspec isn't respecting the include- is that a problem?
Co-authored-by: Riley Karson <[email protected]>
Co-authored-by: Riley Karson <[email protected]>
Not a big deal |
/gcbrun |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 37 insertions(+), 15 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=185686" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendService_internalLoadBalancing|TestAccComputeNodeGroup_nodeGroupAutoscalingPolicyExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=185688" |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 37 insertions(+), 15 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=185787" |
closes hashicorp/terraform-provider-google#4275
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)