Support IP Range Reservation for Global Address. #469
Conversation
chrisst
force-pushed
the
ip-range-reservation
branch
from
3764815 to
e47ebfe
Compare
|
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
products/compute/api.yaml
Outdated
|
|
||
| * VPC_PEERING - for peer networks | ||
|
|
||
| For regional internal addresses, it can be |
There was a problem hiding this comment.
Since this is the GlobalAddress resource, I don't think this value is worth documenting.
Since then it seems like there's only one value this field could take, I'm curious if it's something that we should actually give users the option to set. I assume there's a difference between setting it to VPC_PEERING and just not setting it at all?
products/compute/api.yaml
Outdated
| - :VPC_PEERING | ||
| - :GCE_ENDPOINT | ||
| min_version: beta | ||
| - !ruby/object:Api::Type::String |
There was a problem hiding this comment.
this should be a resourceref, and then you won't need the diffsuppress in terraform.yaml since it'll happen automatically
chrisst
force-pushed
the
ip-range-reservation
branch
from
98e777b to
89aa567
Compare
chrisst
force-pushed
the
ip-range-reservation
branch
from
89aa567 to
99f4a03
Compare
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit 0c97dc0) have been included in your existing downstream PRs. |
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit f985cec) have been included in your existing downstream PRs. |
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit e2c7b45) have been included in your existing downstream PRs. |
Tracked submodules are build/puppet/_bundle build/puppet/auth build/puppet/bigquery build/puppet/compute build/puppet/sql build/puppet/storage build/puppet/spanner build/puppet/container build/puppet/dns build/puppet/pubsub build/puppet/resourcemanager build/chef/_bundle build/chef/auth build/chef/compute build/chef/sql build/chef/storage build/chef/spanner build/chef/container build/chef/dns build/chef/iam build/terraform build/ansible.
[all]
[terraform]
Supporting IP range reservation for global address
[puppet]
[puppet-bigquery]
[puppet-compute]
[puppet-container]
[puppet-dns]
[puppet-logging]
[puppet-pubsub]
[puppet-resourcemanager]
[puppet-sql]
[puppet-storage]
[chef]
[chef-compute]
[chef-container]
[chef-dns]
[chef-logging]
[chef-spanner]
[chef-sql]
[chef-storage]
[ansible]