Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Added data source google kms secret asymmetric" #4651

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

melinath
Copy link
Member

@melinath melinath commented Apr 1, 2021

Reverts #4609. The tests are failing in CI because default credentials aren't available. https://ci-oss.hashicorp.engineering/project.html?projectId=GoogleCloud&testNameId=-1291169185712475134&tab=testDetails


@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 470 deletions(-))
Terraform Beta: Diff ( 6 files changed, 470 deletions(-))
TF Conversion: Diff ( 1 file changed, 22 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=180200"

@modular-magician
Copy link
Collaborator

Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:

```release-note:TYPE
Release note
```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants