Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Updated datatype for mtu" #4643

Merged
merged 4 commits into from
Apr 2, 2021
Merged

Conversation

ScottSuarez
Copy link
Contributor

@ScottSuarez ScottSuarez commented Mar 31, 2021

Reverts #4601
closes hashicorp/terraform-provider-google#8791
reopens hashicorp/terraform-provider-google#8707

compute: reverted datatype change for `mtu` in `google_compute_interconnect_attachment` as it was incompatible with existing state representation

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 2 insertions(+), 15 deletions(-))
Terraform Beta: Diff ( 2 files changed, 3 insertions(+), 17 deletions(-))
Ansible: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=179988"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 2 files changed, 6 insertions(+), 14 deletions(-))
Ansible: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=179989"

@ScottSuarez ScottSuarez requested a review from rileykarson March 31, 2021 19:38
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 132 insertions(+), 17 deletions(-))
Terraform Beta: Diff ( 3 files changed, 132 insertions(+), 17 deletions(-))
Ansible: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))
TF OiCS: Diff ( 4 files changed, 121 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=180166"

@ScottSuarez
Copy link
Contributor Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 132 insertions(+), 17 deletions(-))
Terraform Beta: Diff ( 3 files changed, 132 insertions(+), 17 deletions(-))
Ansible: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))
TF OiCS: Diff ( 4 files changed, 121 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=180204"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample|TestAccContainerCluster_withILBSubsetting|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerCluster_regionalWithNodePool|TestAccContainerCluster_withTpu|TestAccContainerCluster_withPrivateClusterConfig|TestAccContainerCluster_withIntraNodeVisibility|TestAccContainerNodePool_nodeLocations|TestAccContainerNodePool_maxPodsPerNode|TestAccContainerNodePool_withGPU|TestAccContainerNodePool_regionalAutoscaling|TestAccContainerNodePool_resize|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerNodePool_EmptyGuestAccelerator|TestAccDataprocClusterIamBinding|TestAccDataprocClusterIamMember|TestAccDataprocClusterIamPolicy|TestAccDataprocCluster_updatable|TestAccDataprocCluster_withStagingBucket|TestAccDataprocCluster_withTempBucket|TestAccDataprocCluster_withInitAction|TestAccDataprocCluster_withConfigOverrides|TestAccDataprocJobIamMember|TestAccDataprocJobIamBinding|TestAccDataprocJobIamPolicy|TestAccDataprocCluster_withServiceAcc|TestAccDataprocJob_updatable|TestAccDataprocJob_PySpark|TestAccDataprocJob_Hadoop|TestAccDataprocJob_Spark|TestAccDataprocJob_Hive|TestAccDataprocJob_Pig|TestAccDataprocJob_SparkSql|TestAccStorageHmacKey_update You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=180319"

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock|TestAccContainerCluster_withILBSubsetting|TestAccDataprocCluster_withConfigOverrides|TestAccContainerNodePool_regionalAutoscaling Please fix these to complete your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Existing google_compute_interconnect_attachment causing plan to fail
3 participants