Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GKE Autopilot in google_container_cluster resource #4591

Merged
merged 7 commits into from
Mar 30, 2021

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Mar 15, 2021

Closes hashicorp/terraform-provider-google#8553
Upstreams hashicorp/terraform-provider-google#8632

Release Note Template for Downstream PRs (will be copied)

container: add support for GKE Autopilot in `google_container_cluster`
container: promoted `networking_mode` to GA in `google_container_cluster`

@google-cla

This comment has been minimized.

@google-cla google-cla bot added the cla: no label Mar 15, 2021
@c2thorn
Copy link
Member Author

c2thorn commented Mar 15, 2021

@paulwilljones mind taking a look at the message above? I added you as an author for this commit, and there is a CLA.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 200 insertions(+), 45 deletions(-))
Terraform Beta: Diff ( 4 files changed, 202 insertions(+), 47 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=177324"

@c2thorn
Copy link
Member Author

c2thorn commented Mar 15, 2021

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 200 insertions(+), 45 deletions(-))
Terraform Beta: Diff ( 3 files changed, 201 insertions(+), 46 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=177327"

@modular-magician

This comment has been minimized.

@modular-magician

This comment has been minimized.

@c2thorn
Copy link
Member Author

c2thorn commented Mar 16, 2021

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 200 insertions(+), 45 deletions(-))
Terraform Beta: Diff ( 5 files changed, 203 insertions(+), 49 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=177521"

@modular-magician

This comment has been minimized.

@modular-magician

This comment has been minimized.

@paulwilljones
Copy link
Contributor

paulwilljones commented Mar 18, 2021

@paulwilljones mind taking a look at the message above? I added you as an author for this commit, and there is a CLA.

Still looking to get the CLA signed with my company. Should be resolve soon (in time for March 29th release).

@paulwilljones
Copy link
Contributor

@paulwilljones mind taking a look at the message above? I added you as an author for this commit, and there is a CLA.

Still looking to get the CLA signed with my company. Should be resolve soon (in time for March 29th release).

I'm told this is now in place through jetstack.io.

@google-cla

This comment has been minimized.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 199 insertions(+), 46 deletions(-))
Terraform Beta: Diff ( 4 files changed, 200 insertions(+), 47 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=178743"

@google-cla

This comment has been minimized.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 195 insertions(+), 46 deletions(-))
Terraform Beta: Diff ( 6 files changed, 199 insertions(+), 49 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=178743"

@google-cla

This comment has been minimized.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 197 insertions(+), 46 deletions(-))
Terraform Beta: Diff ( 4 files changed, 198 insertions(+), 47 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=178776"

@google-cla

This comment has been minimized.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 210 insertions(+), 44 deletions(-))
Terraform Beta: Diff ( 4 files changed, 210 insertions(+), 45 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=179051"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccContainerClusterDatasource_regional|TestAccContainerClusterDatasource_zonal|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample|TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyBasicExample|TestAccContainerCluster_basic|TestAccContainerCluster_withAddons|TestAccContainerCluster_misc|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withNotificationConfig|TestAccContainerCluster_withMasterAuthConfig|TestAccContainerCluster_withMasterAuthConfig_NoCert|TestAccContainerCluster_withNetworkPolicyEnabled|TestAccContainerCluster_withReleaseChannelEnabled|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccContainerCluster_withMasterAuthorizedNetworksConfig|TestAccContainerCluster_regional|TestAccContainerCluster_withTelemetryEnabled|TestAccContainerCluster_regionalWithNodePool|TestAccContainerCluster_regionalWithNodeLocations|TestAccContainerCluster_withTpu|TestAccContainerCluster_withIntraNodeVisibility|TestAccContainerCluster_withNodeConfigScopeAlias|TestAccContainerCluster_withNodeConfig|TestAccContainerCluster_withPrivateClusterConfig|TestAccContainerCluster_withVersion|TestAccContainerCluster_withNodeConfigShieldedInstanceConfig|TestAccContainerCluster_withWorkloadMetadataConfig|TestAccContainerCluster_network|TestAccContainerCluster_withSandboxConfig|TestAccContainerCluster_withNodePoolBasic|TestAccContainerCluster_backend|TestAccContainerCluster_withNodePoolResize|TestAccContainerCluster_withNodePoolAutoscaling|TestAccContainerCluster_withNodePoolMultiple|TestAccContainerCluster_withMaintenanceWindow|TestAccContainerCluster_withNodePoolNodeConfig|TestAccContainerCluster_withRecurringMaintenanceWindow|TestAccContainerCluster_withMaintenanceExclusionWindow|TestAccContainerCluster_withIPAllocationPolicy_existingSecondaryRanges|TestAccContainerCluster_withIPAllocationPolicy_specificSizes|TestAccContainerCluster_withIPAllocationPolicy_specificIPRanges|TestAccContainerCluster_withShieldedNodes|TestAccContainerCluster_nodeAutoprovisioning|TestAccContainerCluster_errorAutopilotLocation|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerCluster_withAutoscalingProfile|TestAccContainerCluster_withWorkloadIdentityConfig|TestAccContainerCluster_nodeAutoprovisioningDefaultsMinCpuPlatform|TestAccContainerCluster_withBinaryAuthorization|TestAccContainerCluster_withAdvancedDatapath|TestAccContainerCluster_errorNoClusterCreated|TestAccContainerCluster_withFlexiblePodCIDR|TestAccContainerCluster_withEnableKubernetesAlpha|TestAccContainerCluster_errorCleanDanglingCluster|TestAccContainerCluster_withMasterAuthorizedNetworksDisabled|TestAccContainerCluster_withDatabaseEncryption|TestAccContainerNodePool_basic|TestAccContainerCluster_withResourceUsageExportConfig|TestAccContainerNodePool_withNodeConfig|TestAccContainerNodePool_nodeLocations|TestAccContainerNodePool_maxPodsPerNode|TestAccContainerNodePool_withSandboxConfig|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccContainerNodePool_withManagement|TestAccContainerNodePool_withKubeletConfig|TestAccContainerNodePool_withLinuxNodeConfig|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerNodePool_withGPU|TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccContainerNodePool_withNodeConfigScopeAlias|TestAccContainerNodePool_regionalAutoscaling|TestAccContainerNodePool_autoscaling|TestAccContainerNodePool_regionalClusters|TestAccContainerNodePool_resize|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerNodePool_ephemeralStorageConfig|TestAccContainerNodePool_EmptyGuestAccelerator|TestAccContainerNodePool_shieldedInstanceConfig|TestAccGKEHubMembership_gkehubMembershipBasicExample|TestAccGKEHubMembership_gkehubMembershipIssuerExample|TestAccNotebooksInstance_notebookInstanceFullExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=179061"

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyBasicExample|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample|TestAccContainerCluster_withTpu|TestAccContainerCluster_withPrivateClusterConfig|TestAccContainerCluster_regionalWithNodePool|TestAccContainerNodePool_maxPodsPerNode|TestAccContainerNodePool_nodeLocations|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerNodePool_EmptyGuestAccelerator|TestAccContainerNodePool_withGPU|TestAccContainerNodePool_regionalAutoscaling|TestAccContainerNodePool_resize|TestAccNotebooksInstance_notebookInstanceFullExample Please fix these to complete your PR

@c2thorn c2thorn requested a review from rileykarson March 29, 2021 20:54
@c2thorn
Copy link
Member Author

c2thorn commented Mar 29, 2021

@rileykarson Should be ready for review again. Failed recording tests are due to quota/intermittent.
Another full container cluster run was done here: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/179055?buildTab=tests

@google-cla

This comment has been minimized.

@c2thorn
Copy link
Member Author

c2thorn commented Mar 30, 2021

Rebased to resolve conflicts from a recent PR

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 210 insertions(+), 44 deletions(-))
Terraform Beta: Diff ( 4 files changed, 210 insertions(+), 45 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=179768"

@google-cla

This comment has been minimized.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 241 insertions(+), 47 deletions(-))
Terraform Beta: Diff ( 4 files changed, 210 insertions(+), 45 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=179792"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample|TestAccContainerCluster_withILBSubsetting|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerCluster_regionalWithNodePool|TestAccContainerCluster_withTpu|TestAccContainerCluster_withPrivateClusterConfig|TestAccContainerCluster_withIntraNodeVisibility|TestAccContainerNodePool_nodeLocations|TestAccContainerNodePool_maxPodsPerNode|TestAccContainerNodePool_withGPU|TestAccContainerNodePool_regionalAutoscaling|TestAccContainerNodePool_resize|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerNodePool_EmptyGuestAccelerator You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=179807"

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock Please fix these to complete your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCP Autopilot Support
4 participants