-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in resource policy docs #4481
Fix typo in resource policy docs #4481
Conversation
Fork Update
Co-authored-by: upodroid <[email protected]>
Co-authored-by: upodroid <[email protected]>
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @melinath, please review this PR or find an appropriate assignee. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @upodroid - It looks like this contains a typo fix and also a change to the pubsub Topic resource. If that was intentional, could you please split the Topic change into a separate PR? Thanks!
Regarding the typo, it looks like the docs don't contain the word "used"; I'm not familiar with this resource, but that seems like it probably doesn't change the meaning from the original so that's fine with me.
I'll approve once the pubsub change is removed.
My bad, the pubsub change from incorrect branch. I'll fix it |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* mark field as updatable Co-authored-by: upodroid <[email protected]> * Fix resource policy documenation Co-authored-by: upodroid <[email protected]> * fix dodgy change
Fixes: hashicorp/terraform-provider-google#8368
https://cloud.google.com/compute/docs/reference/rest/v1/resourcePolicies/insert
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)