Promote healthcare consent API to GA support

[chaopeng]

Change healthcare consent API to GA support

Fix: hashicorp/terraform-provider-google#8179

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

Promote `google_healthcare_consent_store*` to GA support

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ScottSuarez, please review this PR or find an appropriate assignee.

[chaopeng]

cc @nmousavi

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 1086 insertions(+), 25 deletions(-))
Terraform Beta: Diff ( 5 files changed, 58 insertions(+), 72 deletions(-))
TF Conversion: Diff ( 1 file changed, 81 insertions(+))
TF OiCS: Diff ( 3 files changed, 16 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=166691"

[ScottSuarez]

Hi @chaopeng, I notice the header says [not ready] .. that's no problem, but just @ me whenever it is :)

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 1086 insertions(+), 25 deletions(-))
Terraform Beta: Diff ( 6 files changed, 59 insertions(+), 74 deletions(-))
TF Conversion: Diff ( 2 files changed, 262 insertions(+))
TF OiCS: Diff ( 3 files changed, 16 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=176154"

[chaopeng]

@ScottSuarez ready to review.

[ScottSuarez]

/gcbrun

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 1086 insertions(+), 25 deletions(-))
Terraform Beta: Diff ( 6 files changed, 59 insertions(+), 73 deletions(-))
TF Conversion: Diff ( 2 files changed, 262 insertions(+))
TF OiCS: Diff ( 3 files changed, 16 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=176360"

[chaopeng]

Hi @ScottSuarez, I am not able to see the generate-diffs failure log. Can you check what is the issue? Thank you

[ScottSuarez]

google/iam_healthcare_consent_store_generated_test.go:41:24: Sprintf format %d reads arg #1, but call has 0 args
google/iam_healthcare_consent_store_generated_test.go:51:24: Sprintf format %d reads arg #1, but call has 0 args
google/iam_healthcare_consent_store_generated_test.go:77:24: Sprintf format %d reads arg #1, but call has 0 args
google/iam_healthcare_consent_store_generated_test.go:102:24: Sprintf format %d reads arg #1, but call has 0 args
google/iam_healthcare_consent_store_generated_test.go:111:24: Sprintf format %d reads arg #1, but call has 0 args

[ScottSuarez]

curious... trying this locally

[ScottSuarez]

import format was incorrect. Since we don't run import tests on non-ga products it flew under the radar

[ScottSuarez]

/gcbrun

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 1085 insertions(+), 26 deletions(-))
Terraform Beta: Diff ( 5 files changed, 58 insertions(+), 74 deletions(-))
TF Conversion: Diff ( 2 files changed, 262 insertions(+))
TF OiCS: Diff ( 3 files changed, 16 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=176819"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 1085 insertions(+), 26 deletions(-))
Terraform Beta: Diff ( 5 files changed, 58 insertions(+), 74 deletions(-))
TF Conversion: Diff ( 2 files changed, 262 insertions(+))
TF OiCS: Diff ( 3 files changed, 16 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=176820"

[chaopeng]

@ScottSuarez sorry, it still fails

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 1091 insertions(+), 32 deletions(-))
Terraform Beta: Diff ( 6 files changed, 92 insertions(+), 108 deletions(-))
TF Conversion: Diff ( 2 files changed, 262 insertions(+))
TF OiCS: Diff ( 3 files changed, 16 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=176829"

[ScottSuarez]

/gcbrun adding @slevenick

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 1085 insertions(+), 28 deletions(-))
Terraform Beta: Diff ( 5 files changed, 60 insertions(+), 78 deletions(-))
TF Conversion: Diff ( 2 files changed, 262 insertions(+))
TF OiCS: Diff ( 3 files changed, 16 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=176928"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 1085 insertions(+), 28 deletions(-))
Terraform Beta: Diff ( 5 files changed, 60 insertions(+), 78 deletions(-))
TF Conversion: Diff ( 2 files changed, 262 insertions(+))
TF OiCS: Diff ( 3 files changed, 16 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=176928"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccHealthcareConsentStoreIamBindingGenerated|TestAccHealthcareConsentStoreIamMemberGenerated|TestAccHealthcareConsentStoreIamPolicyGenerated|TestAccApiGatewayGateway_apigatewayGatewayBasicExampleUpdated|TestAccHealthcareConsentStore_healthcareConsentStoreIamExample|TestAccHealthcareConsentStore_healthcareConsentStoreBasicExample|TestAccHealthcareConsentStore_healthcareConsentStoreFullExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=176930"

[modular-magician]

Tests failed during RECORDING mode: TestAccApiGatewayGateway_apigatewayGatewayBasicExampleUpdated Please fix these to complete your PR

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccHealthcareConsentStoreIamMemberGenerated|TestAccHealthcareConsentStoreIamPolicyGenerated|TestAccApiGatewayGateway_apigatewayGatewayBasicExampleUpdated|TestAccHealthcareConsentStore_healthcareConsentStoreFullExample|TestAccHealthcareConsentStore_healthcareConsentStoreBasicExample|TestAccHealthcareConsentStore_healthcareConsentStoreIamExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=176933"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccHealthcareConsentStoreIamMemberGenerated|TestAccHealthcareConsentStoreIamPolicyGenerated|TestAccApiGatewayGateway_apigatewayGatewayBasicExampleUpdated|TestAccHealthcareConsentStore_healthcareConsentStoreFullExample|TestAccHealthcareConsentStore_healthcareConsentStoreBasicExample|TestAccHealthcareConsentStore_healthcareConsentStoreIamExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=176934"

[modular-magician]

Tests failed during RECORDING mode: TestAccApiGatewayGateway_apigatewayGatewayBasicExampleUpdated Please fix these to complete your PR

[modular-magician]

Tests failed during RECORDING mode: TestAccApiGatewayGateway_apigatewayGatewayBasicExampleUpdated Please fix these to complete your PR

[chaopeng]

@ScottSuarez sorry, it still fails

[ScottSuarez]

@chaopeng failed due to an unrelated flakey test. This is good to go. Just going to wait for Sam to sign off

[slevenick]

Looks good to me! The escaped interpolated string is a little gross, but the whole system gets a little weird when a field can include / characters