Marked terraform provider imports as v3 #4309
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to GoogleCloudPlatform/terraform-validator#158. TLDR we need to do semantic versioning for the providers so that they can be imported as libraries (specifically by terraform-validator.) There are just a couple of spots in magic-modules that reference a package version, so we need to update those; otherwise, go will try to install v1 of the package alongside v3.
This has two companion PRs that update the module name for the two providers:
This will not break people using the providers, because those are specially built binaries rather than terraform using the package as a library.
Release Note Template for Downstream PRs (will be copied)