Promote resource policy to GA

[upodroid]

Fixes: hashicorp/terraform-provider-google#7872

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: promoted `google_compute_resource_policy` to GA

[upodroid]

What is this error?

 REDACTED  MCW0CDP3YY  ~  go  …  github.com  hashicorp  terraform-provider-google   master  11⬇  40✎  1  $    make testacc TEST=./google TESTARGS="-run TestAccDataSourceComputeResourcePolicy"
==> Checking source code against gofmt...
==> Checking that code complies with gofmt requirements...
go generate  ./...
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google -v -run TestAccDataSourceComputeResourcePolicy -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccDataSourceComputeResourcePolicy
=== PAUSE TestAccDataSourceComputeResourcePolicy
=== CONT  TestAccDataSourceComputeResourcePolicy
    TestAccDataSourceComputeResourcePolicy: testing_new_config.go:95: no "id" found in attributes
    TestAccDataSourceComputeResourcePolicy: testing_new.go:48: no "id" found in attributes
--- FAIL: TestAccDataSourceComputeResourcePolicy (41.39s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-google/google   43.722s
FAIL
make: *** [testacc] Error 1

Also bundle fails to compile when I change the file extensions from .go.erb to .go

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@c2thorn, please review this PR or find an appropriate assignee.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 190 insertions(+))

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 119 insertions(+))
Terraform Beta: Diff ( 2 files changed, 13 insertions(+), 84 deletions(-))

[c2thorn]

@upodroid there's a known issue with Terraform 0.13+ and data source tests that is probably affecting that test. Our CI is currently running at 0.12.29, and I successfully ran the test with that

[c2thorn]

Also bundle fails to compile when I change the file extensions from .go.erb to .go

Is it because of the autogen_exception line? otherwise i'm not too sure. I don't think converting is particularly necessary though. Did you still want to make any more changes?

[upodroid]

It works now so merge it. I had issues when I renamed the extension to .go and stripped all the Ruby elements from the file.

[c2thorn]

/gcbrun

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=160875"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 119 insertions(+))
Terraform Beta: Diff ( 2 files changed, 13 insertions(+), 84 deletions(-))

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceComposerEnvironment_basic|TestAccDataSourceComputeResourcePolicy|TestAccDataSourceSpannerInstance_basic|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccBigqueryDataTransferConfig|TestAccCloudSchedulerJob_schedulerJobHttpExample|TestAccComposerEnvironment_withUpdateOnCreate|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccFilestoreInstance_filestoreInstanceBasicExample|TestAccFilestoreInstance_update|TestAccOSLoginSSHPublicKey_osLoginSshKeyExpiry You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=160964"