-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description and disabled to logging sinks #4233
Add description and disabled to logging sinks #4233
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=157624" |
@googlebot I fixed it. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable. A couple of the tests don't have the fields they are supposed to be testing
third_party/terraform/tests/resource_logging_billing_account_sink_test.go
Show resolved
Hide resolved
third_party/terraform/tests/resource_logging_billing_account_sink_test.go
Show resolved
Hide resolved
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=157732" |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=157734" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceCloudIdentityGroupMemberships_basic|TestAccDataSourceSpannerInstance_basic|TestAccApiGatewayApiConfigIamBindingGenerated|TestAccApiGatewayApiConfigIamMemberGenerated|TestAccApiGatewayApiConfigIamPolicyGenerated|TestAccApiGatewayGatewayIamBindingGenerated|TestAccApiGatewayGatewayIamMemberGenerated|TestAccApiGatewayGatewayIamPolicyGenerated|TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExample|TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExampleUpdated|TestAccApiGatewayGateway_apigatewayGatewayBasicExample|TestAccApiGatewayGateway_apigatewayGatewayBasicExampleUpdated|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccBigqueryDataTransferConfig|TestAccComposerEnvironment_withUpdateOnCreate|TestAccFilestoreInstance_filestoreInstanceBasicExample|TestAccFilestoreInstance_update|TestAccHealthcareConsentStore_healthcareConsentStoreIamExample|TestAccLoggingBillingAccountSink_update|TestAccLoggingBillingAccountSink_described|TestAccLoggingBillingAccountSink_heredoc|TestAccLoggingBillingAccountSink_disabled|TestAccLoggingFolderSink_described|TestAccLoggingFolderSink_heredoc|TestAccLoggingFolderSink_disabled|TestAccLoggingOrganizationSink_described|TestAccLoggingOrganizationSink_disabled|TestAccLoggingOrganizationSink_heredoc|TestAccLoggingProjectSink_heredoc|TestAccOSLoginSSHPublicKey_osLoginSshKeyExpiry|TestAccStorageBucket_cors You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=157750" |
…-modules into upstream-logging-sink
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=157751" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceCloudIdentityGroupMemberships_basic|TestAccDataSourceSpannerInstance_basic|TestAccApiGatewayApiConfigIamBindingGenerated|TestAccApiGatewayApiConfigIamMemberGenerated|TestAccApiGatewayApiConfigIamPolicyGenerated|TestAccApiGatewayGatewayIamMemberGenerated|TestAccApiGatewayGatewayIamBindingGenerated|TestAccApiGatewayGatewayIamPolicyGenerated|TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExample|TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExampleUpdated|TestAccApiGatewayGateway_apigatewayGatewayBasicExample|TestAccApiGatewayGateway_apigatewayGatewayBasicExampleUpdated|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccBigqueryDataTransferConfig|TestAccComposerEnvironment_withUpdateOnCreate|TestAccFilestoreInstance_filestoreInstanceBasicExample|TestAccFilestoreInstance_update|TestAccHealthcareConsentStore_healthcareConsentStoreIamExample|TestAccLoggingBillingAccountSink_update|TestAccLoggingBillingAccountSink_described|TestAccLoggingBillingAccountSink_heredoc|TestAccLoggingBillingAccountSink_disabled|TestAccLoggingFolderSink_described|TestAccLoggingFolderSink_disabled|TestAccLoggingFolderSink_heredoc|TestAccLoggingOrganizationSink_described|TestAccLoggingOrganizationSink_disabled|TestAccLoggingOrganizationSink_heredoc|TestAccLoggingProjectSink_heredoc|TestAccOSLoginSSHPublicKey_osLoginSshKeyExpiry|TestAccStorageBucket_cors You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=157754" |
Upstreaming 7795
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)